17930 - AGM Extensions Emailer #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
commented
Nov 23, 2023
| @@ -6,7 +6,7 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta name="referrer" content="origin-when-cross-origin"/> | |||
| <meta name="author" content="BC Registries and Online Services"> | |||
| <title>Confirmation of continuation out</title> | |||
| <title>Confirmation of AGM Location Change</title> | |||
There was a problem hiding this comment.
Found this small typo.
JazzarKarim
commented
Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 77.37% 70.66% -6.71%
==========================================
Files 202 26 -176
Lines 11602 1524 -10078
Branches 1961 227 -1734
==========================================
- Hits 8977 1077 -7900
+ Misses 2043 373 -1670
+ Partials 582 74 -508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Argus, can you please suppress the SC code smell? I don't think it's an issue right? This is since I see the table tag in all the templates. |
JazzarKarim
commented
Nov 24, 2023
|
|
||
| society_list = ['SO', 'XSO'] | ||
| return legal_type in society_list | ||
|
|
There was a problem hiding this comment.
Lint errors from previous PRs (not ours).
argush3
reviewed
Nov 24, 2023
queue_services/entity-emailer/src/entity_emailer/message_tracker/tracker.py
Outdated
Show resolved
Hide resolved
|
Looks good! Just the two things I mentioned in the comments. |
queue_services/entity-emailer/src/entity_emailer/email_processors/agm_extension_notification.py
Show resolved
Hide resolved
argush3
approved these changes
Nov 27, 2023
JazzarKarim
force-pushed
the
17930-agm-extensions-emailer
branch
from
8ea69f6 to
9bdf113
Compare
JazzarKarim
force-pushed
the
17930-agm-extensions-emailer
branch
from
9bdf113 to
9eaa7a1
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#17930
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).