11550 - AmalgamaTING and TED Business Summary PDF #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshyun24
requested review from
vysakh-menon-aot,
argush3,
chenhongjing and
PaulGarewal
tshyun24
commented
Jan 19, 2024
| @@ -1,4 +1,4 @@ | |||
| {% if stateFilings|length > 0 %} | |||
| {% if stateFilings|length > 0 and not business.isAmalgamating %} | |||
There was a problem hiding this comment.
confirm with Yui, the amalgamaTING shouldn't have this section
tshyun24
commented
Jan 19, 2024
| @@ -412,6 +422,8 @@ def _format_state_filing(self, filing: Filing) -> dict: | |||
| continuation_out_date = LegislationDatetime.as_legislation_timezone_from_date_str( | |||
| filing_meta['continuationOut']['continuationOutDate']) | |||
| filing_info['continuationOutDate'] = continuation_out_date.strftime(OUTPUT_DATE_FORMAT) | |||
| elif filing.filing_type == 'amalgamationApplication': | |||
| filing_info['filingName'] = 'Amalgamation' | |||
There was a problem hiding this comment.
Confirm with Yui, this one should be amalgamation, instead of amalgamated in the previous Mockups
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 77.37% 76.56% -0.81%
==========================================
Files 202 168 -34
Lines 11602 10559 -1043
Branches 1961 1794 -167
==========================================
- Hits 8977 8085 -892
+ Misses 2043 1987 -56
+ Partials 582 487 -95
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
vysakh-menon-aot
approved these changes
Jan 19, 2024
|
So just wanted to verify the old COOP amalgamations still load and display as per before? I think @Paul-Garewal verified that awhile back in a ticket he was working on so he might have a business identifier you can use to verify if you haven't done that already. |
|
Looks good! Thanks for checking the business summaries for COOPs with amalgs. |
argush3
approved these changes
Jan 19, 2024
chenhongjing
approved these changes
Jan 19, 2024
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 7, 2024
* AmalTED pdf * Amalgamating pdf * remove Dissolution/Restoration Information section * fix lint error * lint with flake8 * lint
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 19, 2024
* AmalTED pdf * Amalgamating pdf * remove Dissolution/Restoration Information section * fix lint error * lint with flake8 * lint
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
* AmalTED pdf * Amalgamating pdf * remove Dissolution/Restoration Information section * fix lint error * lint with flake8 * lint
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 26, 2024
* AmalTED pdf * Amalgamating pdf * remove Dissolution/Restoration Information section * fix lint error * lint with flake8 * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#11550
Description of changes:
modify TED Business Summary PDF
modify TING Business Summary PDF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).