Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18803 Add amalgamation email #2406

Merged
merged 10 commits into from
Jan 23, 2024
Merged

18803 Add amalgamation email #2406

merged 10 commits into from
Jan 23, 2024

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Jan 23, 2024

Issue #: /bcgov/entity#18803

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@vysakh-menon-aot
Copy link
Collaborator

@kzdev420 can you make sure you assign yourself as Assignees for your pr's

@kzdev420 kzdev420 self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (79511cd) 77.37% compared to head (4efd942) 69.38%.
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   77.37%   69.38%   -8.00%     
==========================================
  Files         202       27     -175     
  Lines       11602     1597   -10005     
  Branches     1961      238    -1723     
==========================================
- Hits         8977     1108    -7869     
+ Misses       2043      412    -1631     
+ Partials      582       77     -505     
Flag Coverage Δ
entityemailer 69.38% <53.60%> (?)
entityfiler ?
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvices/entity-emailer/src/entity_emailer/config.py 100.00% <100.00%> (ø)
...mailer/email_processors/correction_notification.py 76.41% <100.00%> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py 83.96% <100.00%> (ø)
...vices/entity-emailer/src/entity_emailer/version.py 100.00% <100.00%> (ø)
...iler/email_processors/special_resolution_helper.py 69.64% <0.00%> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 67.14% <0.00%> (ø)
...ler/email_processors/agm_extension_notification.py 65.38% <65.38%> (ø)
...ail_processors/agm_location_change_notification.py 65.38% <65.38%> (ø)
...entity_emailer/email_processors/nr_notification.py 69.23% <36.66%> (ø)
...iler/email_processors/amalgamation_notification.py 47.61% <47.61%> (ø)

... and 219 files with indirect coverage changes

@@ -0,0 +1,181 @@
# Copyright © 2021 Province of British Columbia
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@@ -0,0 +1,51 @@
# Copyright © 2022 Province of British Columbia
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

14.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzdev420 kzdev420 merged commit e87a735 into bcgov:main Jan 23, 2024
5 of 7 checks passed
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 7, 2024
* 18803 add amalgamation email

* fix small

* fix lint issue

* fix small

* fix the get_filing parts

* fix small

* fix the test

* fix lint issue

* fix lint issue

* update version
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 19, 2024
* 18803 add amalgamation email

* fix small

* fix lint issue

* fix small

* fix the get_filing parts

* fix small

* fix the test

* fix lint issue

* fix lint issue

* update version
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 20, 2024
* 18803 add amalgamation email

* fix small

* fix lint issue

* fix small

* fix the get_filing parts

* fix small

* fix the test

* fix lint issue

* fix lint issue

* update version
PaulGarewal pushed a commit to PaulGarewal/lear that referenced this pull request Mar 26, 2024
* 18803 add amalgamation email

* fix small

* fix lint issue

* fix small

* fix the get_filing parts

* fix small

* fix the test

* fix lint issue

* fix lint issue

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants