-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18803 Add amalgamation email #2406
Conversation
@kzdev420 can you make sure you assign yourself as Assignees for your pr's |
queue_services/entity-emailer/src/entity_emailer/email_processors/amalgamation_notification.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
- Coverage 77.37% 69.38% -8.00%
==========================================
Files 202 27 -175
Lines 11602 1597 -10005
Branches 1961 238 -1723
==========================================
- Hits 8977 1108 -7869
+ Misses 2043 412 -1631
+ Partials 582 77 -505
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -0,0 +1,181 @@ | |||
# Copyright © 2021 Province of British Columbia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,51 @@ | |||
# Copyright © 2022 Province of British Columbia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
Quality Gate failedFailed conditions 14.7% Duplication on New Code (required ≤ 3%) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 18803 add amalgamation email * fix small * fix lint issue * fix small * fix the get_filing parts * fix small * fix the test * fix lint issue * fix lint issue * update version
* 18803 add amalgamation email * fix small * fix lint issue * fix small * fix the get_filing parts * fix small * fix the test * fix lint issue * fix lint issue * update version
* 18803 add amalgamation email * fix small * fix lint issue * fix small * fix the get_filing parts * fix small * fix the test * fix lint issue * fix lint issue * update version
* 18803 add amalgamation email * fix small * fix lint issue * fix small * fix the get_filing parts * fix small * fix the test * fix lint issue * fix lint issue * update version
Issue #: /bcgov/entity#18803
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).