Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18803 Add amalgamation tracker #2426

Merged
merged 2 commits into from
Jan 31, 2024
Merged

18803 Add amalgamation tracker #2426

merged 2 commits into from
Jan 31, 2024

Conversation

kzdev420
Copy link
Collaborator

Issue #: /bcgov/entity#18803

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 self-assigned this Jan 31, 2024
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (59d0e3d) 76.56% compared to head (563f390) 75.63%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
- Coverage   76.56%   75.63%   -0.93%     
==========================================
  Files         169      196      +27     
  Lines       10599    12173    +1574     
  Branches     1802     2038     +236     
==========================================
+ Hits         8115     9207    +1092     
- Misses       1996     2402     +406     
- Partials      488      564      +76     
Flag Coverage Δ
entityemailer 69.38% <46.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gal-api/src/legal_api/reports/business_document.py 49.11% <ø> (+0.42%) ⬆️
legal-api/src/legal_api/reports/report.py 24.79% <ø> (-0.01%) ⬇️
...pi/src/legal_api/resources/v2/business/business.py 65.62% <ø> (ø)
legal-api/src/legal_api/services/__init__.py 78.57% <ø> (-1.43%) ⬇️
legal-api/src/legal_api/services/authz.py 97.29% <ø> (-0.08%) ⬇️
...es/filings/validations/amalgamation_application.py 91.66% <ø> (+0.36%) ⬆️
legal-api/src/legal_api/version.py 100.00% <ø> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py 83.96% <ø> (ø)
...vices/entity-emailer/src/entity_emailer/version.py 100.00% <100.00%> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 67.14% <0.00%> (ø)
... and 1 more

... and 23 files with indirect coverage changes

@kzdev420 kzdev420 merged commit 0ba2e7e into bcgov:main Jan 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants