19043 foreign_corp_num to foreign_identifier

[vysakh-menon-aot]

Issue #: /bcgov/entity#19043

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (59d0e3d) 76.56% compared to head (0e9be47) 77.07%.
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
+ Coverage   76.56%   77.07%   +0.51%     
==========================================
  Files         169      212      +43     
  Lines       10599    12404    +1805     
  Branches     1802     2101     +299     
==========================================
+ Hits         8115     9561    +1446     
- Misses       1996     2215     +219     
- Partials      488      628     +140     

Flag	Coverage Δ
entityfiler	80.36% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...-api/src/legal_api/models/amalgamating_business.py	100.00% <ø> (ø)
...gal-api/src/legal_api/reports/business_document.py	49.11% <ø> (+0.42%)	⬆️
legal-api/src/legal_api/reports/report.py	24.79% <ø> (-0.01%)	⬇️
...pi/src/legal_api/resources/v2/business/business.py	65.62% <ø> (ø)
legal-api/src/legal_api/services/__init__.py	78.57% <ø> (-1.43%)	⬇️
legal-api/src/legal_api/services/authz.py	97.29% <ø> (-0.08%)	⬇️
...es/filings/validations/amalgamation_application.py	89.77% <ø> (-1.54%)	⬇️
...gal_api/services/filings/validations/validation.py	77.77% <ø> (-0.18%)	⬇️
legal-api/src/legal_api/version.py	100.00% <ø> (ø)
...iler/filing_processors/amalgamation_application.py	70.10% <50.00%> (ø)

... and 42 files with indirect coverage changes

[sonarqubecloud]

Quality Gate failed

Failed conditions

17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[vysakh-menon-aot]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (59d0e3d) 76.56% compared to head (0e9be47) 77.07%.
Report is 20 commits behind head on main.

Additional details and impacted files

Will add additional test in my next ticket (short form amalgamation)