Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19405 Add missed dependency #2447

Merged
merged 1 commit into from
Feb 7, 2024
Merged

19405 Add missed dependency #2447

merged 1 commit into from
Feb 7, 2024

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Feb 7, 2024

Issue #: /bcgov/entity#19405

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 requested a review from argush3 February 7, 2024 17:02
@kzdev420 kzdev420 self-assigned this Feb 7, 2024
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (59d0e3d) 76.56% compared to head (69aa40e) 67.41%.
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
- Coverage   76.56%   67.41%   -9.16%     
==========================================
  Files         169      204      +35     
  Lines       10599    13251    +2652     
  Branches     1802     1776      -26     
==========================================
+ Hits         8115     8933     +818     
- Misses       1996     3832    +1836     
+ Partials      488      486       -2     
Flag Coverage Δ
colinapi 32.36% <70.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
colin-api/src/colin_api/__init__.py 97.22% <100.00%> (ø)
colin-api/src/colin_api/services/__init__.py 100.00% <100.00%> (ø)
...-api/src/legal_api/models/amalgamating_business.py 100.00% <ø> (ø)
legal-api/src/legal_api/models/party_role.py 98.76% <ø> (-0.02%) ⬇️
...gal-api/src/legal_api/reports/business_document.py 49.11% <ø> (+0.42%) ⬆️
legal-api/src/legal_api/reports/report.py 24.79% <ø> (-0.01%) ⬇️
...pi/src/legal_api/resources/v2/business/business.py 64.51% <ø> (-1.11%) ⬇️
...egal_api/resources/v2/business/business_parties.py 100.00% <ø> (ø)
legal-api/src/legal_api/services/__init__.py 78.57% <ø> (-1.43%) ⬇️
legal-api/src/legal_api/services/authz.py 97.29% <ø> (-0.08%) ⬇️
... and 4 more

... and 32 files with indirect coverage changes

@kzdev420 kzdev420 merged commit b724198 into bcgov:main Feb 7, 2024
5 of 7 checks passed
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 19, 2024
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 19, 2024
JazzarKarim pushed a commit to JazzarKarim/lear that referenced this pull request Mar 20, 2024
PaulGarewal pushed a commit to PaulGarewal/lear that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants