19904 email updates for amalgamation application #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -298,8 +298,7 @@ def get_ar_dates(self, next_ar_year): | |||
| ar_min_date = datetime(next_ar_year, self.founding_date.month, self.founding_date.day).date() | |||
| ar_max_date = ar_min_date + datedelta.datedelta(days=60) | |||
|
|
|||
| if ar_max_date > datetime.utcnow().date(): | |||
| ar_max_date = datetime.utcnow().date() | |||
| ar_max_date = min(ar_max_date, datetime.utcnow().date()) # ar_max_date cannot be in future | |||
There was a problem hiding this comment.
A new pylint error says Consider using 'ar_max_date = min(ar_max_date, datetime.utcnow().date())' instead of unnecessary if block (consider-using-min-builtin)
|
| @@ -81,7 +81,7 @@ def get(identifier, filing_id=None): # pylint: disable=too-many-return-statemen | |||
| if not rv.storage: | |||
| return jsonify({'message': f'{identifier} no filings found'}), HTTPStatus.NOT_FOUND | |||
| if str(request.accept_mimetypes) == 'application/pdf' and filing_id: | |||
| if rv.filing_type == 'incorporationApplication': | |||
| if rv.filing_type in ['amalgamationApplication', 'incorporationApplication']: | |||
There was a problem hiding this comment.
unfortunately we are still using v1 resources to get documents in entity-emailer
| @@ -134,30 +135,60 @@ def _get_pdfs( | |||
| def process(email_info: dict, token: str) -> dict: # pylint: disable=too-many-locals, , too-many-branches | |||
| """Build the email for Amalgamation notification.""" | |||
| logger.debug('filing_notification: %s', email_info) | |||
| amalgamation_application_names = { | |||
There was a problem hiding this comment.
We could use legal_api/core/meta/filing.py to get displayName but it will cause issues when we merge legal name branch (as we won't keep legal-api dependency anymore)
vysakh-menon-aot
requested review from
argush3,
jamespaologarcia and
ketaki-deodhar
argush3
approved these changes
Feb 27, 2024
ketaki-deodhar
approved these changes
Feb 27, 2024
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
added a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
added a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 26, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19904
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).