20179 get amalgamated into from version data #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
==========================================
- Coverage 75.49% 75.35% -0.15%
==========================================
Files 196 196
Lines 12264 12319 +55
Branches 2054 2065 +11
==========================================
+ Hits 9259 9283 +24
- Misses 2442 2471 +29
- Partials 563 565 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
vysakh-menon-aot
requested review from
PaulGarewal,
argush3,
jamespaologarcia and
ketaki-deodhar
| def get_amalgamation_revision_obj(cls, transaction_id, business_id): | ||
| """Get amalgamation for the given transaction id.""" | ||
| # pylint: disable=singleton-comparison; | ||
| amalgamation_version = version_class(Amalgamation) |
There was a problem hiding this comment.
@argush3 Introducing the version data in model
jamespaologarcia
approved these changes
Mar 15, 2024
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
added a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
pushed a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
JazzarKarim
added a commit
to JazzarKarim/lear
that referenced
this pull request
Mar 20, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 26, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20179
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).