19808 Fixed vaults.gcp.env for entity-pay #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argush3
reviewed
Apr 5, 2024
Comment on lines
2
to
3
| ENTITY_FILER_TOPIC="op://gcp-queue/$APP_ENV/payment/ENTITY_FILER_TOPIC" | ||
| ENTITY_MAILER_TOPIC="op://gcp-queue/$APP_ENV/payment/ENTITY_MAILER_TOPIC" |
There was a problem hiding this comment.
I think this should be the following? i.e. using the "topics" section
ENTITY_FILER_TOPIC="op://gcp-queue/$APP_ENV/topics/ENTITY_FILER_TOPIC"
ENTITY_MAILER_TOPIC="op://gcp-queue/$APP_ENV/topics/ENTITY_MAILER_TOPIC"
There was a problem hiding this comment.
I see, so there's a vault for the topics. I thought each one would be in it's respective project. OK, I'll fix that too for the other vaults.gcp.env.
JazzarKarim
commented
Apr 5, 2024
| @@ -32,7 +32,7 @@ NATS_FILER_SUBJECT="op://nats/$APP_ENV/nats-filer/NATS_FILER_SUBJECT" | |||
| NATS_ENTITY_EVENT_SUBJECT="op://nats/$APP_ENV/nats-filer/NATS_ENTITY_EVENT_SUBJECT" | |||
| NATS_EMAILER_SUBJECT="op://nats/$APP_ENV/nats-emailer/NATS_EMAILER_SUBJECT" | |||
| AUDIENCE="op://gcp-queue/$APP_ENV/payment/AUDIENCE" | |||
| TOPIC_NAME="op://gcp-queue/$APP_ENV/filer/TOPIC_NAME" | |||
There was a problem hiding this comment.
we can probably remove the TOPIC_NAME from the filer vault. Thoughts Argus?
There was a problem hiding this comment.
Let's just keep the TOPIC_NAME for each service for now. I think it was designed this way on purpose for the topic that is being subscribed to.
|
argush3
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19808
Description of changes:
I'm going to try testing after this PR is merged. Depending on what I find, i'll be making the code changes necessary.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).