Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21124 Legal API - update allowable actions #2716

Merged
merged 3 commits into from
May 27, 2024

Conversation

AimeeGao
Copy link
Collaborator

Issue #: /bcgov/entity#21124

Description of changes:

  • Update allowable actions to block following filings types if business is in dissolution. This PR is a good reference

    • Voluntary dissolution
    • Alteration
    • Amalgamation
  • Use new in_dissolution property in business model to help in determining if a business is in the process of being dissolved

  • Add/update unit tests as appropriate

  • Update allowable actions spreadsheet to include new rules

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
62.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐱 BTW, you don't have to copy all the things from description of ticket to PR's description of changes. Just briefly describe your code changes.

@AimeeGao
Copy link
Collaborator Author

LGTM 🐱 BTW, you don't have to copy all the things from description of ticket to PR's description of changes. Just briefly describe your code changes.

Got it, thanks for the tip, I will keep it brief next time 😄

Copy link
Collaborator

@leodube-aot leodube-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kzdev420 kzdev420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AimeeGao AimeeGao merged commit 1a99962 into bcgov:main May 27, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants