-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21124 Legal API - update allowable actions #2716
Conversation
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐱 BTW, you don't have to copy all the things from description of ticket to PR's description of changes. Just briefly describe your code changes.
Got it, thanks for the tip, I will keep it brief next time 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #: /bcgov/entity#21124
Description of changes:
Update allowable actions to block following filings types if business is in dissolution. This PR is a good reference
Use new in_dissolution property in business model to help in determining if a business is in the process of being dissolved
Add/update unit tests as appropriate
Update allowable actions spreadsheet to include new rules
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).