Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21208 update AR filing to withdraw businesses in dissolution where appropriate #2739

Merged
merged 18 commits into from
Jun 24, 2024
Merged

21208 update AR filing to withdraw businesses in dissolution where appropriate #2739

merged 18 commits into from
Jun 24, 2024

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Jun 5, 2024

Issue #: /bcgov/entity#21208

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@JazzarKarim
Copy link
Collaborator

There's a SonarCloud issue:
sc issue

Would you be able to fix it please?

@JazzarKarim
Copy link
Collaborator

There's a lint error as well. Thanks.

@argush3
Copy link
Collaborator

argush3 commented Jun 10, 2024

please add tests to show your code works

Copy link

gitguardian bot commented Jun 11, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9442085 Triggered Generic Password a2e1542 .github/workflows/involuntary-dissolutions-ci.yml View secret
9442085 Triggered Generic Password a2e1542 .github/workflows/involuntary-dissolutions-ci.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kzdev420 kzdev420 marked this pull request as ready for review June 11, 2024 22:00
@argush3
Copy link
Collaborator

argush3 commented Jun 21, 2024

please rebase and resolve conflicts so i can see if your tests pass

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (81aac8e) to head (9be6513).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
+ Coverage   75.49%   81.64%   +6.14%     
==========================================
  Files         196       42     -154     
  Lines       12264     1923   -10341     
  Branches     2054      353    -1701     
==========================================
- Hits         9259     1570    -7689     
+ Misses       2442      197    -2245     
+ Partials      563      156     -407     
Flag Coverage Δ
entityemailer ?
entityfiler 81.64% <100.00%> (?)
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/entity_filer/filing_processors/annual_report.py 93.54% <100.00%> (ø)
...e_services/entity-filer/src/entity_filer/worker.py 82.19% <100.00%> (ø)

... and 236 files with indirect coverage changes

Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one last comment.

Will approve once that's in place and tests check out in CI.

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzdev420 kzdev420 merged commit bc11ad5 into bcgov:main Jun 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants