-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21208 update AR filing to withdraw businesses in dissolution where appropriate #2739
21208 update AR filing to withdraw businesses in dissolution where appropriate #2739
Conversation
There's a lint error as well. Thanks. |
queue_services/entity-filer/src/entity_filer/filing_processors/dissolution.py
Outdated
Show resolved
Hide resolved
please add tests to show your code works |
…date_AR_filing_to_withdraw_business_in_dissolution
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9442085 | Triggered | Generic Password | a2e1542 | .github/workflows/involuntary-dissolutions-ci.yml | View secret |
9442085 | Triggered | Generic Password | a2e1542 | .github/workflows/involuntary-dissolutions-ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Quality Gate failedFailed conditions |
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
queue_services/entity-filer/src/entity_filer/filing_processors/annual_report.py
Show resolved
Hide resolved
…date_AR_filing_to_withdraw_business_in_dissolution
…date_AR_filing_to_withdraw_business_in_dissolution
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Show resolved
Hide resolved
please rebase and resolve conflicts so i can see if your tests pass |
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
…date_AR_filing_to_withdraw_business_in_dissolution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2739 +/- ##
==========================================
+ Coverage 75.49% 81.64% +6.14%
==========================================
Files 196 42 -154
Lines 12264 1923 -10341
Branches 2054 353 -1701
==========================================
- Hits 9259 1570 -7689
+ Misses 2442 197 -2245
+ Partials 563 156 -407
Flags with carried forward coverage won't be shown. Click here to find out more.
|
queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the one last comment.
Will approve once that's in place and tests check out in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #: /bcgov/entity#21208
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).