21777 add exclude future effective filing flag #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argush3
requested review from
leodube-aot,
JazzarKarim,
AimeeGao and
eason-pan-bc
argush3
reviewed
Jul 2, 2024
|
Can we add relevant tests to verify that dissolution related warnings are able to return even when there is a future effective filing? We'll want to test change of address for sure as this was what broke the warnings code. |
Yes, I will add the test too |
…ffective_filing parameters
…ffective_filing parameters
…for_dissolution' of https://github.com/kzdev420/lear into 21777_add_exclude_future_effective_filing_crietia_flag_for_dissolution
chenhongjing
reviewed
Jul 3, 2024
eason-pan-bc
reviewed
Jul 3, 2024
argush3
reviewed
Jul 3, 2024
argush3
reviewed
Jul 3, 2024
argush3
reviewed
Jul 3, 2024
argush3
approved these changes
Jul 3, 2024
chenhongjing
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#21777
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).