22617 - Added max_size column to Batch #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
requested review from
argush3,
kzdev420,
chenhongjing and
leodube-aot
jobs/involuntary-dissolutions/tests/unit/test_involuntary_dissolutions.py
Show resolved
Hide resolved
JazzarKarim
force-pushed
the
22617-add-maxsize-column
branch
from
b83089e
to
3a17655
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#22617
Description of changes:
Before:
After:
Unit Tests:
I know the unit tests fail here but that's because github is building the batch model from the remote legal api, i.e: lear\jobs\involuntary-dissolutions\venv\lib\python3.8\site-packages\legal_api\models\batch.py
After this PR is merged, the unit tests should work normally?
I added the max_size to the file noted above and all tests pass:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).