24153 fixes in colin sync #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysakh-menon-aot
commented
Nov 4, 2024
Comment on lines
-178
to
-199
| # return the completed filing data | ||
| completed_filing = Filing() | ||
| # get business info again - could have changed since filings were applied | ||
| completed_filing.business = Business.find_by_identifier(identifier, con=con) | ||
| completed_filing.body = {} | ||
| for filing_info in filings_added: | ||
| sub_filing = Filing() | ||
| sub_filing.business = completed_filing.business | ||
| sub_filing.filing_type = filing_info['filing_type'] | ||
| sub_filing.filing_sub_type = filing_info['filing_sub_type'] | ||
| sub_filing.event_id = filing_info['event_id'] | ||
| sub_filing = Filing.get_filing(filing=sub_filing, con=con) | ||
|
|
||
| if completed_filing.header: | ||
| completed_filing.header['colinIds'].append(sub_filing.event_id) | ||
| # annual report is the only filing with sub filings underneath it | ||
| if sub_filing.filing_type == 'annualReport': | ||
| completed_filing.header['name'] = 'annualReport' | ||
| else: | ||
| completed_filing.header = sub_filing.header | ||
| completed_filing.body.update({sub_filing.filing_type: sub_filing.body}) | ||
|
|
There was a problem hiding this comment.
this result is not needed
vysakh-menon-aot
requested review from
argush3,
thorwolpert and
ketaki-deodhar
|
argush3
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#24153
Description of changes:
ORA-01830: date format picture ends before converting entire input string(COD filing_date)'NoneType' object has no attribute 'upper'update-colin-filingschanged logic of fetching filings with offset instead of paginate (to avoid calculation)update_legal_filingsremoved sync of CORPS from colin -> lear (this is not accepted anymore). Still have logic for COOP's, seems like it may be in use. Not in a position to work on COOP'sBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).