HAPP-1868: Handle special authority with no title

spotless
bcgov · Mar 7, 2024 · e458279 · e458279
1 parent 65815bb
commit e458279
Show file tree

Hide file tree

Showing 6 changed files with 89 additions and 9 deletions.
diff --git a/app/src/main/java/ca/bc/gov/bchealth/MainActivity.kt b/app/src/main/java/ca/bc/gov/bchealth/MainActivity.kt
@@ -18,6 +18,7 @@ import androidx.work.WorkManager
 import ca.bc.gov.bchealth.databinding.ActivityMainBinding
 import ca.bc.gov.bchealth.ui.inappupdate.InAppUpdateActivity
 import ca.bc.gov.bchealth.utils.InAppUpdateHelper
+import ca.bc.gov.bchealth.utils.showPartialRecordsErrorMessage
 import ca.bc.gov.bchealth.utils.showServiceDownMessage
 import ca.bc.gov.bchealth.utils.viewBindings
 import ca.bc.gov.bchealth.viewmodel.AnalyticsFeatureViewModel
@@ -169,6 +170,14 @@ class MainActivity : AppCompatActivity() {
                 binding.navHostFragment.showServiceDownMessage(this)
                 return
             }
+
+            if (workData.getBoolean(
+                    FetchAuthenticatedHealthRecordsWorker.FailureReason.PARTIAL_RECORDS_ERROR.value,
+                    false
+                )
+            ) {
+                binding.navHostFragment.showPartialRecordsErrorMessage(this)
+            }
         }
     }
 

diff --git a/app/src/main/java/ca/bc/gov/bchealth/usecases/records/FetchSpecialAuthoritiesUseCase.kt b/app/src/main/java/ca/bc/gov/bchealth/usecases/records/FetchSpecialAuthoritiesUseCase.kt
@@ -1,5 +1,6 @@
 package ca.bc.gov.bchealth.usecases.records
 
+import ca.bc.gov.common.exceptions.PartialRecordsException
 import ca.bc.gov.common.model.AuthParametersDto
 import ca.bc.gov.common.model.specialauthority.SpecialAuthorityDto
 import ca.bc.gov.repository.di.IoDispatcher
@@ -20,7 +21,19 @@ class FetchSpecialAuthoritiesUseCase @Inject constructor(
             authParameters, specialAuthorityRepository::getSpecialAuthority
         )
 
-        insertSpecialAuthority(patientId, specialAuthorities)
+        var filteredOut = false
+        val filteredList = specialAuthorities?.filter {
+            val hasTitle = it.drugName.isNullOrBlank().not()
+            if (hasTitle.not()) {
+                filteredOut = true
+            }
+            hasTitle
+        }
+
+        insertSpecialAuthority(patientId, filteredList)
+        if (filteredOut) {
+            throw PartialRecordsException()
+        }
     }
 
     private suspend fun insertSpecialAuthority(

diff --git a/app/src/main/java/ca/bc/gov/bchealth/utils/Extensions.kt b/app/src/main/java/ca/bc/gov/bchealth/utils/Extensions.kt
@@ -223,6 +223,10 @@ fun View.showNoInternetConnectionMessage(context: Context) {
     showErrorSnackbar(context.getString(R.string.no_internet_connection))
 }
 
+fun View.showPartialRecordsErrorMessage(context: Context) {
+    showErrorSnackbar(context.getString(R.string.partial_records_error_message))
+}
+
 fun View?.showErrorSnackbar(message: String, anchor: View? = null) {
     this ?: return
 

diff --git a/app/src/main/java/ca/bc/gov/bchealth/workers/FetchAuthenticatedHealthRecordsWorker.kt b/app/src/main/java/ca/bc/gov/bchealth/workers/FetchAuthenticatedHealthRecordsWorker.kt
@@ -20,6 +20,7 @@ import ca.bc.gov.bchealth.usecases.records.FetchPatientDataUseCase
 import ca.bc.gov.bchealth.usecases.records.FetchSpecialAuthoritiesUseCase
 import ca.bc.gov.bchealth.usecases.records.FetchVaccinesUseCase
 import ca.bc.gov.common.BuildConfig.LOCAL_API_VERSION
+import ca.bc.gov.common.exceptions.PartialRecordsException
 import ca.bc.gov.common.model.AuthParametersDto
 import ca.bc.gov.common.model.dependents.DependentDto
 import ca.bc.gov.repository.DependentsRepository
@@ -110,7 +111,11 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
             return Result.failure()
         }
 
-        val isApiFailed = loadRecords(patientId, authParameters, dependents)
+        val isApiFailed = try {
+            loadRecords(patientId, authParameters, dependents)
+        } catch (e: PartialRecordsException) {
+            return respondToFailure(FailureReason.PARTIAL_RECORDS_ERROR, true)
+        }
 
         return if (isApiFailed) {
             return respondToFailure(FailureReason.IS_RECORD_FETCH_FAILED, true)
@@ -130,7 +135,9 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
             val tasks = mutableListOf<Deferred<ListenableWorker.Result>>()
             val dataSetFlag = mobileConfigRepository.getPatientDataSetFeatureFlags()
 
-            if (dataSetFlag.isMedicationEnabled()) { tasks.add(async { fetchMedicationsUseCase.execute(patientId, authParameters) }) }
+            if (dataSetFlag.isMedicationEnabled()) {
+                tasks.add(async { fetchMedicationsUseCase.execute(patientId, authParameters) })
+            }
 
             if (dataSetFlag.isClinicalDocumentEnabled()) {
                 tasks.add(
@@ -154,9 +161,27 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
                 )
             }
 
-            if (dataSetFlag.isHealthVisitEnabled()) { tasks.add(runTaskAsync { fetchHealthVisitsUseCase.execute(patientId, authParameters) }) }
+            if (dataSetFlag.isHealthVisitEnabled()) {
+                tasks.add(
+                    runTaskAsync {
+                        fetchHealthVisitsUseCase.execute(
+                            patientId,
+                            authParameters
+                        )
+                    }
+                )
+            }
 
-            if (dataSetFlag.isHospitalVisitEnabled()) { tasks.add(runTaskAsync { fetchHospitalVisitsUseCase.execute(patientId, authParameters) }) }
+            if (dataSetFlag.isHospitalVisitEnabled()) {
+                tasks.add(
+                    runTaskAsync {
+                        fetchHospitalVisitsUseCase.execute(
+                            patientId,
+                            authParameters
+                        )
+                    }
+                )
+            }
 
             if (dataSetFlag.isImmunizationEnabled()) {
                 tasks.add(
@@ -169,9 +194,20 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
                 )
             }
 
-            if (dataSetFlag.isLabResultEnabled()) { tasks.add(runTaskAsync { fetchLabOrdersUseCase.execute(patientId, authParameters) }) }
+            if (dataSetFlag.isLabResultEnabled()) {
+                tasks.add(runTaskAsync { fetchLabOrdersUseCase.execute(patientId, authParameters) })
+            }
 
-            if (dataSetFlag.isSpecialAuthorityRequestEnabled()) { tasks.add(runTaskAsync { fetchSpecialAuthoritiesUseCase.execute(patientId, authParameters) }) }
+            if (dataSetFlag.isSpecialAuthorityRequestEnabled()) {
+                tasks.add(
+                    runTaskAsync {
+                        fetchSpecialAuthoritiesUseCase.execute(
+                            patientId,
+                            authParameters
+                        )
+                    }
+                )
+            }
 
             tasks.add(
                 runTaskAsync {
@@ -185,7 +221,14 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
 
             val taskResult = tasks.awaitAll()
 
-            isApiFailed = taskResult.contains(Result.failure())
+            val failedTasks = taskResult.filter { it != Result.success() }
+            failedTasks.forEach {
+                val data = it.outputData
+                data.getBoolean(FailureReason.PARTIAL_RECORDS_ERROR.value, true)
+                throw PartialRecordsException()
+            }
+
+            isApiFailed = failedTasks.isNotEmpty()
         }
         return isApiFailed
     }
@@ -214,6 +257,10 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
             try {
                 task.invoke()
                 Result.success()
+            } catch (e: PartialRecordsException) {
+                Log.e("RecordsWorker", "Handling Exception:")
+                e.printStackTrace()
+                respondToFailure(FailureReason.PARTIAL_RECORDS_ERROR, true)
             } catch (e: Exception) {
                 Log.e("RecordsWorker", "Handling Exception:")
                 e.printStackTrace()
@@ -228,6 +275,7 @@ class FetchAuthenticatedHealthRecordsWorker @AssistedInject constructor(
     enum class FailureReason(val value: String) {
         APP_UPDATE_REQUIRED("appUpdateRequired"),
         IS_HG_SERVICES_UP("isHgServicesUp"),
-        IS_RECORD_FETCH_FAILED("IS_RECORD_FETCH_FAILED")
+        IS_RECORD_FETCH_FAILED("IS_RECORD_FETCH_FAILED"),
+        PARTIAL_RECORDS_ERROR("PARTIAL_RECORDS_ERROR")
     }
 }
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -455,6 +455,7 @@
     <string name="service_down">Maintenance is underway. Please try later.</string>
     <string name="dismiss">Dismiss</string>
     <string name="no_internet_connection">Unable to refresh your data. Please check your internet connection.</string>
+    <string name="partial_records_error_message">Some partial records were not displayed.</string>
     <string name="comments_error_max_character">Maximum 1000 characters</string>
 
     <!--Timeline View-->

diff --git a/common/src/main/java/ca/bc/gov/common/exceptions/PartialRecordsException.kt b/common/src/main/java/ca/bc/gov/common/exceptions/PartialRecordsException.kt
@@ -0,0 +1,5 @@
+package ca.bc.gov.common.exceptions
+
+class PartialRecordsException(
+    message: String? = null
+) : Exception(message)