17468 Fixed missing location for aml #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set initial location for aml
severinbeauvais
changed the base branch from
main
to
feature-search-refactor
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-698-xm3x7h3d.web.app |
ketaki-deodhar
approved these changes
Sep 15, 2023
severinbeauvais
commented
Sep 15, 2023
| @@ -129,8 +129,8 @@ import { Component, Vue } from 'vue-property-decorator' | |||
| components: { NameBuildInfo, NewAndBetterWay } | |||
| }) | |||
| export default class LowerContainer extends Vue { | |||
| private needMoreInfo = 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/' + | |||
There was a problem hiding this comment.
This cause a warning in the template that the variable wasn't accessible.
leodube-aot
approved these changes
Sep 15, 2023
severinbeauvais
merged commit 35086b5
into
bcgov:feature-search-refactor
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#17468
Description of changes:
- app version = 5.1.10
- set initial location for aml
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).