Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17144: Duplicate name request issue. #716

Merged
merged 11 commits into from
Oct 20, 2023
Merged

Conversation

Rajandeep98
Copy link
Contributor

@Rajandeep98 Rajandeep98 commented Sep 27, 2023

…ta, created exception to catch error for duplicates

Issue #: bcgov/entity#17144

Description of changes:

  • pop up added for user

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but you need to rebase please).

@Rajandeep98
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-716-7ctou01e.web.app

Copy link
Collaborator

@ozamani9gh ozamani9gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Rajandeep98
Copy link
Contributor Author

/gcbrun

@Rajandeep98
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@ozamani9gh ozamani9gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@eve-git
Copy link
Collaborator

eve-git commented Oct 20, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-716-7ctou01e.web.app

@ozamani9gh ozamani9gh merged commit 3a99da9 into bcgov:main Oct 20, 2023
5 checks passed
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.15",
"version": "5.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you increased the minor release number instead of the patch number.

Anyways, it's fine this time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i told her to bump it up 5.3.0 because i assumed all of the WoN was incrementing from 5.2.1 all the way up to .14

i wanted to start anew with 5.3.0 let us know if you want the next version to go back to 5.2.15

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So 5.3.0 is "post WoN", lol.

Just leave it. It's fine.

Copy link
Collaborator

@severinbeauvais severinbeauvais Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, your decision gives us the option to continue hotfixes on 5.2.x 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants