-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#17144: Duplicate name request issue. #716
Conversation
…ta, created exception to catch error for duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but you need to rebase please).
/gcbrun |
Temporary Url for review: https://namerequest-dev--pr-716-7ctou01e.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
/gcbrun |
Temporary Url for review: https://namerequest-dev--pr-716-7ctou01e.web.app |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "name-request", | |||
"version": "5.2.15", | |||
"version": "5.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you increased the minor release number instead of the patch number.
Anyways, it's fine this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i told her to bump it up 5.3.0 because i assumed all of the WoN was incrementing from 5.2.1 all the way up to .14
i wanted to start anew with 5.3.0 let us know if you want the next version to go back to 5.2.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So 5.3.0 is "post WoN", lol.
Just leave it. It's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, your decision gives us the option to continue hotfixes on 5.2.x 👍
…ta, created exception to catch error for duplicates
Issue #: bcgov/entity#17144
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).