Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18299 fix xpro A -> XCR mapping #736

Merged
merged 2 commits into from
Oct 24, 2023
Merged

18299 fix xpro A -> XCR mapping #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe42155
- app version = 5.2.14.a
severinbeauvais Oct 24, 2023
064e2e6
- fixed Xpro REH and CHG mapping: XUL should be XCR
severinbeauvais Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.14",
"version": "5.2.14a",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is a hotfix and there is already a 5.2.15.

"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
8 changes: 4 additions & 4 deletions src/list-data/request-action-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,16 @@ export const XproMapping: RequestActionMappingI = {
REH: [
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
EntityTypes.XCR, // maps to Corp Type "EXTRA_PRO_A"
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. XCR === A
  2. I sorted this list.
  3. I removed XUL from below as per original NR code (before WoN changes).

EntityTypes.XSO // maps to Corp Type "XS"
],
CHG: [
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XCR, // maps to Corp Type "EXTRA_PRO_A"
EntityTypes.XLL, // maps to Corp Type "XL"
EntityTypes.XLP, // maps to Corp Type "XP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
EntityTypes.XSO // maps to Corp Type "XS"
]
}

Expand Down
18 changes: 9 additions & 9 deletions src/mixins/common-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export class CommonMixin extends Vue {
*/
entityTypeToCorpType (entityType: EntityTypes): CorpTypeCd {
switch (entityType) {
case EntityTypes.A: return CorpTypeCd.EXTRA_PRO_A // same as XUL
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not a valid Namerequest entity type.

case EntityTypes.BC: return CorpTypeCd.BENEFIT_COMPANY
case EntityTypes.CC: return CorpTypeCd.BC_CCC
case EntityTypes.CP: return CorpTypeCd.COOP
Expand All @@ -77,13 +76,13 @@ export class CommonMixin extends Vue {
case EntityTypes.SO: return CorpTypeCd.SOCIETY
case EntityTypes.UL: return CorpTypeCd.BC_ULC_COMPANY
case EntityTypes.XCP: return CorpTypeCd.XPRO_COOP
case EntityTypes.XCR: return CorpTypeCd.XPRO_CORPORATION
case EntityTypes.XCR: return CorpTypeCd.EXTRA_PRO_A
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCR === A

Copy link
Collaborator

@JazzarKarim JazzarKarim Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah man. Again, these can be soo confusing. On paper it sounds like EXTRA_PRO_A is EntityTypes.A, but apparently that's not the case. Just like how BC is a benefit company but CR is a limited company.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😠

case EntityTypes.XL: return CorpTypeCd.XPRO_LL_PARTNR // same as XLL
case EntityTypes.XLL: return CorpTypeCd.XPRO_LL_PARTNR
case EntityTypes.XLP: return CorpTypeCd.XPRO_LIM_PARTNR
case EntityTypes.XP: return CorpTypeCd.XPRO_LIM_PARTNR // same as XLP
case EntityTypes.XSO: return CorpTypeCd.XPRO_SOCIETY
case EntityTypes.XUL: return CorpTypeCd.EXTRA_PRO_A
case EntityTypes.XUL: return CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the correct mapping, although I think we don't actually use XUL in Namerequest.

Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be precise, Namex API seems to support XUL <-> A mappings, ie

image

However, the XUL <-> XUL mapping entries in Legal API are currently commented out, meaning they're not supported in Lear atm, ie

image

Interestingly, the XCR <-> XCR mapping entries in Lear are also commented out. This makes sense, since users need to go to COLIN to use XCR name requests... We will likely revisit this when we move over the final types from COLIN to LEAR. Good luck to us!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A problem to keep in mind for the future haha 😅

default: return null
}
}
Expand All @@ -99,7 +98,7 @@ export class CommonMixin extends Vue {
case CorpTypeCd.BC_COMPANY: return EntityTypes.CR
case CorpTypeCd.BC_ULC_COMPANY: return EntityTypes.UL
case CorpTypeCd.COOP: return EntityTypes.CP
case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XUL
case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XCR
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A === XCR

case CorpTypeCd.FINANCIAL: return EntityTypes.FI
case CorpTypeCd.PARTNERSHIP: return EntityTypes.GP
case CorpTypeCd.LIMITED_CO: return EntityTypes.RLC
Expand All @@ -114,6 +113,7 @@ export class CommonMixin extends Vue {
case CorpTypeCd.XPRO_LIM_PARTNR: return EntityTypes.XLP
case CorpTypeCd.XPRO_LL_PARTNR: return EntityTypes.XLL
case CorpTypeCd.XPRO_SOCIETY: return EntityTypes.XSO
case CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY: return EntityTypes.XUL
default: return null
}
}
Expand Down Expand Up @@ -212,13 +212,13 @@ export class CommonMixin extends Vue {
/** Returns true if the specified entity type is for an Extraprovincial Company. */
isXproEntityType (type: EntityTypes): boolean {
return [
EntityTypes.XCR,
EntityTypes.XUL,
EntityTypes.RLC,
EntityTypes.XLP,
EntityTypes.XLL,
EntityTypes.XCP,
EntityTypes.XSO
EntityTypes.XCR,
EntityTypes.XLL,
EntityTypes.XLP,
EntityTypes.XSO,
EntityTypes.XUL
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply sorted this list.

I left XUL in there even though I I think we don't actually use it in Namerequest.

].includes(type)
}

Expand Down
Loading