Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18286 correct entity_type_cd for the request type BECR #739

Merged
merged 4 commits into from
Oct 25, 2023
Merged

18286 correct entity_type_cd for the request type BECR #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d949fff
correct entity_type_cd for the request type BECR
eve-git Oct 24, 2023
61f7643
Merge branch 'bcgov:main' into 18286
eve-git Oct 25, 2023
dd783c8
update version
eve-git Oct 25, 2023
3892ffa
Merge branch '18286' of https://github.com/eve-git/namerequest into 1…
eve-git Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.3.1",
"version": "5.3.2",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion src/components/new-request/search-components/business-lookup-fetch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
:hint="hint"
@click:append="onBusiness(null)"
@keyup.delete="onBusiness(null)"
@keydown.enter.native.prevent

Check warning on line 32 in src/components/new-request/search-components/business-lookup-fetch.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

'.native' modifier on 'v-on' directive is deprecated
/>
</v-form>
</v-col>
Expand Down Expand Up @@ -121,7 +121,7 @@
// set conversionType and entityTypeCd because there's only one alteration type for it
if (this.isBenBusiness) {
this.setConversionType(NrRequestTypeCodes.CONVERT_CORP)
this.setEntityTypeCd(EntityTypes.BC)
this.setEntityTypeCd(EntityTypes.CR)
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
}
} else {
// clear all related fields when clearing business search/fetch for alter
Expand Down
1 change: 0 additions & 1 deletion src/mixins/search-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ export class SearchMixin extends Mixins(CommonMixin) {
const entityType = ConversionTypes.find(conv => conv.value === nrRequestType)?.entity_type_cd || null
this.setEntityTypeCd(entityType)
this.setConversionType(type)
this.setConversionType(type)
return
}

Expand Down
Loading