Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18115 get keycload token from rootState #742

Merged
merged 3 commits into from
Oct 31, 2023
Merged

18115 get keycload token from rootState #742

merged 3 commits into from
Oct 31, 2023

Conversation

eve-git
Copy link
Collaborator

@eve-git eve-git commented Oct 27, 2023

Issue #: bcgov/entity#18115

Description of changes:
After login, get KeyCloak Token from rootState

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@eve-git
Copy link
Collaborator Author

eve-git commented Oct 27, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-742-czgygd0s.web.app

Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcgov bcgov deleted a comment from bcregistry-sre Oct 27, 2023
@severinbeauvais
Copy link
Collaborator

I think this is ready to merge, except I know Names Team is preparing for a release so I don't know if this should go into Dev yet.

@eve-git
Copy link
Collaborator Author

eve-git commented Oct 27, 2023

Will merge after the release on next Tuesday

@eve-git eve-git merged commit 3fe5d0c into bcgov:main Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants