Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18178 previous val not clearing #745

Merged
merged 2 commits into from
Nov 8, 2023
Merged

18178 previous val not clearing #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3985d52
PR - Cleared company type
jamespaologarcia Nov 8, 2023
0db15a9
Removed console log
jamespaologarcia Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.3.6",
"version": "5.3.7",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/components/new-request/search-components/entity-type.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
:content-class="!isScreenLg ? 'left-tooltip' : ''"
transition="fade-transition"
>
<template #activator="scope">

Check warning on line 44 in src/components/new-request/search-components/entity-type.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Variable 'scope' is already declared in the upper scope
<span
class="list-item"
:class="{ 'last-select-item': item.value === 'INFO' }"
Expand Down Expand Up @@ -103,6 +103,7 @@
@Watch('getEntityTypeCd')
private clearDesignation () {
this.setDesignation('')
this.setSearchCompanyType('')
// clear "Select a Business Type" field when "View all business types" is selected
if (!this.getEntityTypeCd || this.getEntityTypeCd === EntityTypes.INFO) {
this.$refs.selectBusinessTypeRef && this.$refs.selectBusinessTypeRef.reset()
Expand Down
Loading