Hide Action button when changing name and Go To Colin Button visible #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot in supported change name FF
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-757-p8kfadau.web.app |
eve-git
requested review from
severinbeauvais,
ketaki-deodhar,
rarmitag and
mengdong19
severinbeauvais
approved these changes
Apr 17, 2024
|
@eve-git , did you change the FF to test this scenario (as described in the ticket)? |
Yes, I changed FF and tested, it worked on both of the two options. I think the coding logic is good too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
bcgov/entity#20529
Description of changes:
Hide action button when changing name to a numbered name and the legal type is not supported by FF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).