Fix typos and readability on PR 1570

[RMCampos]

User Story

As a user, I want to have no typos and easy to read code, when possible.

Acceptance Criteria

• Fix MINITRY_OF_FORESTS_ID typo in the config.Constants class;
• Change current implementation making easier to understand.

Additional Notes

Suggestion:

public static List<String> getClientIdsFromJwt(Jwt jwtPrincipal) {
  List<String> clientIds = new ArrayList<>();
  boolean foundRole = false;
  
  List<String> rolesAndClientIds = getRolesWithClientIds(jwtPrincipal);
  for (String role: rolesAndClientIds) {
    if (role.length() >= 9) {
      String clientNumber = role.substring(role.length() - 8);
      if (clientNumber.replaceAll("[0-9]", "").isEmpty()) {
        clientIds.add(clientNumber);
      }
    }

    if (concreteRoles.contains(role)) {
      foundRole = true;
    }
  }

  // If has role SPAR_MINISTRY_ORCHARD or SPAR_TSC_ADMIN and has no client id
  // then add MOF client id
  if (foundRole && !clientIds.contains(Constants.MINITRY_OF_FORESTS_ID)) {
    clientIds.add(Constants.MINITRY_OF_FORESTS_ID);
  }

  return clientIds;
}

• Original PR fix: add client id to concrete roles #1570