Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Scenario #2 for Email refactoring/improving according to docs (Private Cloud) #2513

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Fix: Scenario #2 for Email refactoring/improving according to docs (Private Cloud) #2513

merged 5 commits into from
Apr 19, 2024

Conversation

Amritpal-Nijjar
Copy link
Contributor

  1. Fixed subject line for admin email
  2. fixed punctuation in edit request email
  3. admins now see comments from user for an edit request
  4. added logic for sending the correct email based on type of request (edit vs create)
  5. updated the documentation for scenario 2 approval and rejection emails
  6. rejection email now shows what was rejected (what quota was rejected)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Amritpal-Nijjar Amritpal-Nijjar merged commit f918dd9 into main Apr 19, 2024
2 of 3 checks passed
@Amritpal-Nijjar Amritpal-Nijjar deleted the fix/2432 branch April 19, 2024 21:41
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junminahn junminahn junminahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amritpal-Nijjar @junminahn