Fix validation in Home Owner Transfers

bcgov · Jul 3, 2024 · 251a585 · 251a585
1 parent 015089c
commit 251a585
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 5 deletions.
diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.2.30",
+  "version": "3.2.31",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

diff --git a/ppr-ui/src/composables/mhrRegistration/useHomeOwners.ts b/ppr-ui/src/composables/mhrRegistration/useHomeOwners.ts
@@ -200,7 +200,7 @@ export function useHomeOwners (isMhrTransfer: boolean = false, isMhrCorrection:
     const hasNoGroups = [HomeTenancyTypes.SOLE, HomeTenancyTypes.JOINT].includes(getHomeTenancyType()) ||
       groups.length === 0
 
-    return !hasNoGroups || !groups || groups.length >= 2 ||
+    return hasNoGroups || !groups || groups.length >= 2 ||
       (!showGroups.value && groups.length === 1)
   }
 

diff --git a/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts b/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts
@@ -45,10 +45,54 @@ import {
 } from '@/enums'
 import { DeathCertificate, SupportingDocuments } from '@/components/mhrTransfers'
 import { transferSupportingDocuments, transfersErrors, MixedRolesErrors } from '@/resources'
-import { useNewMhrRegistration } from '@/composables'
+import { useHomeOwners, useNewMhrRegistration } from '@/composables'
 
 const store = useStore()
 
+describe('useHomeOwners composable', () => {
+  it('test hasMinimumGroups', async () => {
+
+    // setup owners structure where 3 groups of sole owners were removed
+    // and one owner was added
+    const homeOwnerGroups: MhrRegistrationHomeOwnerGroupIF[] = [
+      {
+        groupId: 1,
+        interest: 'Undivided',
+        interestDenominator: 2,
+        interestNumerator: 1,
+        owners: [mockedRemovedPerson],
+        type: HomeTenancyTypes.SOLE,
+        action: ActionTypes.REMOVED
+      },
+      {
+        groupId: 2,
+        interest: 'Undivided',
+        interestDenominator: 2,
+        interestNumerator: 1,
+        owners: [mockedRemovedPerson],
+        type: HomeTenancyTypes.SOLE,
+        action: ActionTypes.REMOVED
+      },
+      {
+        groupId: 3,
+        owners: [mockedAddedPerson],
+        type: HomeTenancyTypes.SOLE,
+        action: ActionTypes.ADDED
+      }
+    ]
+
+    await store.setMhrTransferHomeOwnerGroups(homeOwnerGroups)
+    await store.setMhrTransferType({ transferType: ApiTransferTypes.SALE_OR_GIFT } as TransferTypeSelectIF)
+
+    const useHomeOwnersComposable = useHomeOwners(true)
+    useHomeOwnersComposable.setShowGroups(true)
+
+    const { hasMinimumGroups } = useHomeOwnersComposable
+
+    expect(hasMinimumGroups()).toBe(true)
+  })
+})
+
 describe('Home Owners', () => {
   let wrapper