Various Transfer Affe related bug fixes (#1808)

bcgov · Apr 4, 2024 · 4847fce · 4847fce
1 parent 5014525
commit 4847fce
Show file tree

Hide file tree

Showing 10 changed files with 63 additions and 41 deletions.
diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.0.77",
+  "version": "3.0.78",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

diff --git a/ppr-ui/src/components/mhrTransfers/ConfirmCompletion.vue b/ppr-ui/src/components/mhrTransfers/ConfirmCompletion.vue
@@ -31,7 +31,7 @@
               <ol>
                 <li
                   v-if="isTransferDueToSaleOrGift"
-                  class="pl-3 pb-3"
+                  class="pl-3 pt-0"
                   data-test-id="bill-of-sale-sale-or-gift"
                 >
                   <p><strong>Bill of sale</strong> meets the following requirements:</p>
@@ -79,7 +79,7 @@
                 </li>
                 <li
                   v-else-if="!isTransferDueToDeath"
-                  class="pl-3 pb-3 mb-7"
+                  class="pl-3 pt-0"
                   data-test-id="bill-of-sale-section"
                 >
                   <p>
@@ -97,7 +97,7 @@
                 </li>
                 <li
                   v-else-if="isTransferDueToDeath"
-                  class="pl-3 pb-3 mb-7"
+                  class="pl-3 pt-0"
                   data-test-id="death-certificate-section"
                 >
                   <p>
@@ -139,21 +139,21 @@
                 </li>
                 <li
                   v-if="isRoleStaff"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="change-ownership-section"
                 >
                   <p><strong>Transfer or Change Ownership form</strong> has been received and retained.</p>
                 </li>
                 <li
                   v-if="isRoleQualifiedSupplier && isTransferDueToSaleOrGift"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="change-ownership-qs"
                 >
                   <p><strong>Transfer or Change Ownership form</strong> has been received and retained.</p>
                 </li>
                 <li
                   v-if="isRoleStaff && isTransferDueToSaleOrGift"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="certified-copy-section"
                 >
                   <p>
@@ -163,38 +163,47 @@
                 </li>
                 <li
                   v-if="isTransferToExecutorProbateWill"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="probate-will-section"
                 >
-                  <p><strong>Court certified true copy of the Grant of Probate with the will attached.</strong></p>
+                  <p>
+                    <strong>Court certified true copy of the Grant of Probate with the will attached </strong>
+                    has been received and retained.
+                  </p>
                 </li>
                 <li
                   v-if="isTransferToAdminNoWill"
-                  class="pl-3 pb-3 mb-7"
+                  class="pl-3"
                 >
-                  <p><strong>Certified true copy of Grant of Administration issued by the court.</strong></p>
+                  <p>
+                    <strong>Court certified true copy of the Grant of Administration</strong> has been received and
+                    retained.
+                  </p>
                 </li>
                 <li
                   v-if="isTransferToAdminNoWill"
-                  class="pl-3 pb-3 mb-7"
+                  class="pl-3"
                 >
-                  <p><strong>Affidavit of Administration with List of Assets and Liabilities.</strong></p>
+                  <p>
+                    <strong>Affidavit of Administration with List of Assets and Liabilities</strong> has been received
+                    and retained.
+                  </p>
                 </li>
                 <li
                   v-if="isTransferToExecutorUnder25Will"
-                  class="pl-3 pb-3 mb-7"
+                  class="pl-3"
                 >
-                  <p><strong>Certified true copy of the will.</strong></p>
+                  <p><strong>Certified true copy of the will</strong> has been received and retained.</p>
                 </li>
                 <li
-                  v-if="isTransferToExecutorUnder25Will"
-                  class="pl-3 pb-3 mb-7"
+                  v-if="isTransferToExecutorUnder25Will || isTransferToExecutorProbateWill"
+                  class="pl-3"
                 >
                   <p><strong>Original signed Affidavit of Executor form</strong> has been received and retained.</p>
                 </li>
                 <li
                   v-if="isTransferDueToSaleOrGift"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="confirm-search-sale-or-gift"
                 >
                   <p>
@@ -210,7 +219,7 @@
                 </li>
                 <li
                   v-else-if="!isTransferDueToDeath"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="confirm-search-section"
                 >
                   <p>
@@ -225,7 +234,7 @@
                 </li>
                 <li
                   v-if="(isTransferDueToSaleOrGift && isRoleStaff) || isTransferToSurvivingJointTenant"
-                  class="pl-3 pb-3"
+                  class="pl-3"
                   data-test-id="ppr-lien-sale-or-gift"
                 >
                   <p>
@@ -251,8 +260,9 @@
                   </ul>
                 </li>
                 <li
-                  v-else-if="(isTransferDueToSaleOrGift && isRoleQualifiedSupplier)"
-                  class="pl-3 pb-3"
+                  v-else-if="(isTransferDueToSaleOrGift && isRoleQualifiedSupplier) || isTransferDueToDeath"
+                  class="pl-3"
+                  data-test-id="ppr-lien-section-blockers"
                 >
                   <p>
                     <strong>Personal Property Registry lien search</strong> has been completed and there are no liens
@@ -437,23 +447,22 @@ export default defineComponent({
   }
 
   .confirm-completion-req, :slotted(*) {
-    margin-bottom: 13px;
     ol {
       padding-left: 27px !important;
     }
     ol:not([type="a"])>li:not(:last-child) {
       border-bottom: 1px solid $gray3;
 
       ::marker {
-        font-weight: bold;
+        font-weight: normal;
       }
     }
     ol>li {
-      padding-top: 15px;
+      padding: 25px 0;
       padding-left: unset;
     }
     ol>li::marker {
-      font-weight: bold;
+      font-weight: normal;
     }
     ul {
       margin-bottom: 16px;

diff --git a/...nts/mhrTransportPermit/ConfirmCompletionContent/AmendTransportPermitConfirmCompletion.vue b/...nts/mhrTransportPermit/ConfirmCompletionContent/AmendTransportPermitConfirmCompletion.vue
@@ -29,10 +29,12 @@
         type="a"
         class="mt-1"
       >
-        <li>
+        <li class="pb-0">
           all local taxes for the current year have been paid
         </li>
-        <li>original location of the home matches the location on the tax certificate</li>
+        <li class="pt-0">
+          original location of the home matches the location on the tax certificate
+        </li>
       </ol>
       <p class="mt-5">
         <strong>Note: </strong>A tax certificate is not required for manufactured homes that are located on a
@@ -57,7 +59,7 @@
       you must report the physical location of the manufactured home within 3 days of expiry of the permit.
       <v-divider class="my-6 ml-n8" />
     </li>
-    <li>
+    <li class="pb-3">
       <strong>If the home is permanently moved to a different location than what is specified on the transport
         permit</strong>, you must report the physical location of the manufactured home within 3 days of the move.
     </li>

diff --git a/...omponents/mhrTransportPermit/ConfirmCompletionContent/LocationChangeConfirmCompletion.vue b/...omponents/mhrTransportPermit/ConfirmCompletionContent/LocationChangeConfirmCompletion.vue
@@ -30,10 +30,12 @@
         type="a"
         class="mt-1"
       >
-        <li>
+        <li class="pb-0">
           is not located on a manufacturer’s or a dealer's lot.
         </li>
-        <li>has not moved to a different pad within the same park.</li>
+        <li class="pt-0">
+          has not moved to a different pad within the same park.
+        </li>
       </ol>
       <v-divider class="my-6 ml-n8" />
     </li>

diff --git a/...mponents/mhrTransportPermit/ConfirmCompletionContent/TransportPermitConfirmCompletion.vue b/...mponents/mhrTransportPermit/ConfirmCompletionContent/TransportPermitConfirmCompletion.vue
@@ -30,10 +30,12 @@
         type="a"
         class="mt-1"
       >
-        <li>
+        <li class="pb-0">
           are not located on a manufacturer’s or a dealer's lot.
         </li>
-        <li>are not moving to a different pad within the same park.</li>
+        <li class="pt-0">
+          are not moving to a different pad within the same park.
+        </li>
       </ol>
       <v-divider class="my-6 ml-n8" />
     </li>
@@ -54,7 +56,7 @@
       report the physical location of the manufactured home within 3 days of expiry of the permit.
       <v-divider class="my-6 ml-n8" />
     </li>
-    <li>
+    <li class="pb-3">
       <strong>If the home is permanently moved to a different location than what is specified on the transport
         permit</strong>, you must report the physical location of the manufactured home within 3 days of the move.
     </li>

diff --git a/ppr-ui/src/enums/unitNoteDocTypes.ts b/ppr-ui/src/enums/unitNoteDocTypes.ts
@@ -9,6 +9,7 @@ export enum UnitNoteDocTypes {
   NOTICE_OF_TAX_SALE = 'TAXN',
   DECAL_REPLACEMENT = 'REG_102',
   TRANSPORT_PERMIT = 'REG_103',
+  AMEND_PERMIT = 'AMEND_PERMIT',
   TRANSPORT_PERMIT_EXTENSION = 'REG_103E',
   NON_RESIDENTIAL_EXEMPTION = 'EXNR',
   RESIDENTIAL_EXEMPTION_ORDER = 'EXRS',

diff --git a/ppr-ui/src/resources/unitNotes.ts b/ppr-ui/src/resources/unitNotes.ts
@@ -108,6 +108,11 @@ export const UnitNotesInfo: Record<UnitNoteDocTypes, UnitNoteInfoIF> = {
     dropdownText: 'Transport Permit',
     fee: FeeSummaryDefaults.NO_FEE
   },
+  [UnitNoteDocTypes.AMEND_PERMIT]: {
+    header: 'Amend Permit',
+    dropdownText: 'Amend Permit',
+    fee: FeeSummaryDefaults.NO_FEE
+  },
   [UnitNoteDocTypes.TRANSPORT_PERMIT_EXTENSION]: {
     header: 'Transport Permit Extension',
     dropdownText: 'Transport Permit Extension',

diff --git a/ppr-ui/src/views/mhrInformation/MhrInformation.vue b/ppr-ui/src/views/mhrInformation/MhrInformation.vue
@@ -387,8 +387,8 @@
                         class="pl-1"
                         color="primary"
                         :ripple="false"
-                        :disabled="(isFrozenMhr || (hasLien && !isLienRegistrationTypeSA)) &&
-                          !isRoleStaffReg || isChangeLocationActive || disableRoleBaseTransfer"
+                        :disabled="isFrozenMhrDueToAffidavit || ((hasLien && !isLienRegistrationTypeSA) &&
+                          (!isRoleStaffReg || isChangeLocationActive || disableRoleBaseTransfer))"
                         @click="toggleTypeSelector()"
                       >
                         <span v-if="!showTransferType">
@@ -438,7 +438,7 @@
                     />
                     <TransferType
                       :validate="validate"
-                      :disableSelect="isFrozenMhrDueToAffidavit && !isRoleStaffReg"
+                      :disableSelect="isFrozenMhrDueToAffidavit"
                       @emitType="handleTransferTypeChange"
                       @emitDeclaredValue="handleDeclaredValueChange"
                       @emitValid="setValidation('isValidTransferType', $event)"
@@ -1171,7 +1171,7 @@ export default defineComponent({
 
             // Set Frozen state manually as the base reg isn't re-fetched in this flow
             await setMhrStatusType(MhApiStatusTypes.FROZEN)
-            await setMhrTransferType({ transferType: ApiTransferTypes.SALE_OR_GIFT })
+            await setMhrTransferType(StaffTransferTypes[1])
             // Set baseline MHR Information to state
             await parseMhrInformation(isFrozenMhr.value)
 

diff --git a/ppr-ui/tests/unit/MhrInformation.spec.ts b/ppr-ui/tests/unit/MhrInformation.spec.ts
@@ -860,7 +860,8 @@ describe('Mhr Information', async () => {
     expect(confirmCompletionCard.find(getTestId('death-certificate-section')).exists()).toBeTruthy()
     expect(confirmCompletionCard.find(getTestId('change-ownership-section')).exists()).toBeTruthy()
     expect(confirmCompletionCard.find(getTestId('probate-will-section')).exists()).toBeTruthy()
-    expect(confirmCompletionCard.find(getTestId('ppr-lien-section')).exists()).toBeTruthy()
+    expect(confirmCompletionCard.find(getTestId('ppr-lien-section-blockers')).exists()).toBeTruthy()
+    expect(confirmCompletionCard.find(getTestId('ppr-lien-section')).exists()).toBeFalsy()
 
     // Doesn't contain any other flow sections
     expect(confirmCompletionCard.find(getTestId('confirm-search-section')).exists()).toBeFalsy()