Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXA fixes for executor icon alignment #1254

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

owillborn
Copy link
Contributor

Issue #: /bcgov/entity#15576

Description of changes:

  • Minor UXA tweaks to properly align new icons

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 1 minor comment you can disregard haha

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1254 (543350c) into main (54bbf27) will decrease coverage by 0.72%.
The diff coverage is 63.54%.

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   72.33%   71.62%   -0.72%     
==========================================
  Files         300      300              
  Lines       12447    12450       +3     
  Branches     2431     2517      +86     
==========================================
- Hits         9004     8917      -87     
- Misses       3432     3521      +89     
- Partials       11       12       +1     
Flag Coverage Δ
pprui 71.62% <63.54%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ppr-ui/src/components/common/Stepper.vue 91.66% <ø> (ø)
ppr-ui/src/components/common/StickyContainer.vue 96.87% <ø> (ø)
...mhrRegistration/HomeOwners/FractionalOwnership.vue 100.00% <ø> (ø)
...rRegistration/ReviewConfirm/HomeLocationReview.vue 63.15% <ø> (ø)
...mhrRegistration/ReviewConfirm/HomeOwnersReview.vue 100.00% <ø> (ø)
...gistration/ReviewConfirm/SubmittingPartyReview.vue 89.28% <ø> (ø)
ppr-ui/src/components/parties/debtor/Debtors.vue 73.33% <ø> (ø)
...ui/src/components/parties/party/SecuredParties.vue 60.36% <ø> (ø)
...c/components/search/BusinessSearchAutocomplete.vue 54.54% <ø> (ø)
ppr-ui/src/components/tables/SearchHistory.vue 54.28% <0.00%> (ø)
... and 65 more

... and 5 files with indirect coverage changes

@cameron-eyds cameron-eyds merged commit 558a1ff into bcgov:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants