Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance MH registration location data validation #1292

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Enhance MH registration location data validation #1292

merged 1 commit into from
Apr 24, 2023

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity#15933

Description of changes:

  • Enhance MH registration location data validation, update unit tests.
  • 15990 fix for reg report transfer joint owner scenario tenancy type.
  • 15269 add mhr_documents.affirm_by to load conversion data.
  • 16074 TAXN document type unit note conditional inclusion on ACTIVE state.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett added the MHR API MHR API changes label Apr 21, 2023
@doug-lovett doug-lovett self-assigned this Apr 21, 2023
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dimak1
Copy link
Collaborator

dimak1 commented Apr 24, 2023

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1292-fqmp7j24.web.app

@doug-lovett doug-lovett merged commit f39a3b9 into bcgov:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR API MHR API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants