Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small validation fix for EffectiveDateTime component #1439

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jul 19, 2023

Description of changes:

  • EffectiveDateTime component was not emitting validation state - this fixes it

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1
Copy link
Collaborator Author

dimak1 commented Jul 19, 2023

/gcbrun

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1439 (0971c38) into main (9255e77) will increase coverage by 4.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   72.35%   77.12%   +4.77%     
==========================================
  Files         307      338      +31     
  Lines       12767     6199    -6568     
  Branches     2630      982    -1648     
==========================================
- Hits         9237     4781    -4456     
+ Misses       3518     1386    -2132     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.12% <ø> (+4.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 134 more

... and 125 files with indirect coverage changes

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1439-34jammkt.web.app

@cameron-eyds cameron-eyds merged commit b4263b9 into bcgov:main Jul 19, 2023
7 checks passed
@dimak1 dimak1 deleted the fix/effective-date-validation branch November 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants