Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 Build #1594

Merged

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Oct 23, 2023

Issue #: /bcgov/entity#16981

Description of changes:

  • Where to begin....
  • Upgrade framework to Vue 3, includes router and main.ts major refactors
  • Upgrade component library to Vuetify 3 - Includes new vuetify plugin
  • Convert projects bundler from Webpack -> Vite - This includes configurations and removal of Webpack/Babel Shtuff
  • Updates to Sbc-common-components 4.0.0 version (now 4.0.1) to include minor fixes on issues that were preventing build.
  • The jist on the above: Resolves alias conflicts experienced by shared @ alias in both project and library. Has been resolved in: 16981 - Alias Updates to preserve @ alias for local project use sbc-common-components#337
  • Removes obsolete packages (ie tiptap vuetify and stuff no longer required or without vue3 support etc)
  • Updated Linting to modern recommendations for Vue, Vuetify and Typescript -- applies fixes (not all): Note this is much stricter than what it was originally but the basic patterns have been set to follow.

Vuetify Specific Notes:

  • The goal here is to create somewhat of a reusable assets directory to be shared between projects. So I've removed about 90% of the styling in Base, Layouts and Overrides and have begun to re-add and re-organize with that in mind. So don't be alarmed when you see lots of styling removed, generally appearances are the same. We had a lot of redundant styling, ie styling that could be achieved by helper classes or refactoring the templates to be a more appropriate landmark tag or p tag etc. Once again, trying to keep things generic and centralize styling.
  • Refactored Components to a functional state up to PPR and MHR Searches and History, this includes our App and Dashboard.

Additional Notes:

  • With the swap to VITE, we will eventually update our test suites to utilize ViTest, to handle in Task specific to Unit Testing

  • I have a checklist of items that i have carried forward to tackle in our Vuetify specific ticket, such as staff payment etc.

  • Lastly, ignore the CI for the time being, we have some updates to make to support the change to VITE and keep in mind this is pointing at a WIP: Feature Branch

  • A small look but for those that are interested can certainly build and use Search related features:
    Screenshot 2023-10-23 at 2 32 47 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the Vue3 Migration Work related to Vue3 migration. label Oct 23, 2023
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive for a step. Not too bad to review, lots of the same changes.

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! Looks good!

ppr-ui/src/components/common/PartyForm.vue Show resolved Hide resolved
ppr-ui/src/components/dialogs/StaffPaymentDialog.vue Outdated Show resolved Hide resolved
ppr-ui/vite.config.js Outdated Show resolved Hide resolved
@dimak1
Copy link
Collaborator

dimak1 commented Oct 24, 2023

Vue 3 🚀

@cameron-eyds
Copy link
Collaborator Author

Just a side note, i started fixing all the linting issues but then reverted them.
They are helpful when fixing each component individually by understanding what the basic issues are. If i fix them all now, i may miss or forget quick fixes that are done now.

@cameron-eyds cameron-eyds merged commit b49bffe into bcgov:Vue3-Upgrade-Feature-Branch Oct 24, 2023
2 of 4 checks passed
cameron-eyds added a commit to cameron-eyds/ppr that referenced this pull request Nov 8, 2023
* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration
cameron-eyds added a commit to cameron-eyds/ppr that referenced this pull request Nov 8, 2023
* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration
cameron-eyds added a commit to cameron-eyds/ppr that referenced this pull request Nov 20, 2023
* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration
cameron-eyds added a commit to cameron-eyds/ppr that referenced this pull request Nov 20, 2023
* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration
cameron-eyds added a commit that referenced this pull request Nov 20, 2023
* Vue3 Build (#1594)

* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration

* Vuetify and component updates - PRR (#1609)

* base dialog and Staff Payment instances updated

* ongoing PPR Table work

* Ongoin PPR Registrations/Amendment updates

* Ongoing PPR Reg - Includes stepper, footers, Bus Search, Base Address

* Ppr Registrations Happy Path

* Chips and other misc fixes for Amendments

* Vuetify Fixes for MHR and Misc Features (#1615)

* Mhr Registrations Happy Path

* Ongoing Registration Table Improvements

* User access Start, some more table clean up

* User Access Fixes + more table updates

* Cleaned up Tables Sorting

* Further Transfer and Unit Note Adjustments

* Masking fixes and replacements

* Date Pickers and misc styling adjustments

* Lint Sweeps and camelCase enforcement

* Reg Table Fix and command revert

* Further DatePicker Updates

* ViTest: Unit Testing Setup/Config/Utils and Ongoing Refactoring (#1623)

* Ongoing Unit Test fixes

* Ongoing PPR Test fixes - Includes base setup - solves most complexity - now test fixes

* more test config updates and unit test fixes

* button-footer rework

* Further Testing updates - Up to Debtors

* continued testing updates DischargeReg

* Tests up to EditTrust and more cleanup

* PR CleanUP

* Few more tests - up to FeeSummary

* FeeSummary test

* Lint update

* fee summary file clean up

* Sync Clean Up

* Ongoing test work

* Delete .idea directory
cameron-eyds added a commit to cameron-eyds/ppr that referenced this pull request Dec 4, 2023
* Vue3 Build (bcgov#1594)

* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration

* Vuetify and component updates - PRR (bcgov#1609)

* base dialog and Staff Payment instances updated

* ongoing PPR Table work

* Ongoin PPR Registrations/Amendment updates

* Ongoing PPR Reg - Includes stepper, footers, Bus Search, Base Address

* Ppr Registrations Happy Path

* Chips and other misc fixes for Amendments

* Vuetify Fixes for MHR and Misc Features (bcgov#1615)

* Mhr Registrations Happy Path

* Ongoing Registration Table Improvements

* User access Start, some more table clean up

* User Access Fixes + more table updates

* Cleaned up Tables Sorting

* Further Transfer and Unit Note Adjustments

* Masking fixes and replacements

* Date Pickers and misc styling adjustments

* Lint Sweeps and camelCase enforcement

* Reg Table Fix and command revert

* Further DatePicker Updates

* ViTest: Unit Testing Setup/Config/Utils and Ongoing Refactoring (bcgov#1623)

* Ongoing Unit Test fixes

* Ongoing PPR Test fixes - Includes base setup - solves most complexity - now test fixes

* more test config updates and unit test fixes

* button-footer rework

* Further Testing updates - Up to Debtors

* continued testing updates DischargeReg

* Tests up to EditTrust and more cleanup

* PR CleanUP

* Few more tests - up to FeeSummary

* FeeSummary test

* Lint update

* fee summary file clean up

* Sync Clean Up

* Ongoing test work

* Delete .idea directory
cameron-eyds added a commit that referenced this pull request Dec 8, 2023
* Ongoing PPR Unit testing (#1626)

* Vue3 Build (#1594)

* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration

* Vuetify and component updates - PRR (#1609)

* base dialog and Staff Payment instances updated

* ongoing PPR Table work

* Ongoin PPR Registrations/Amendment updates

* Ongoing PPR Reg - Includes stepper, footers, Bus Search, Base Address

* Ppr Registrations Happy Path

* Chips and other misc fixes for Amendments

* Vuetify Fixes for MHR and Misc Features (#1615)

* Mhr Registrations Happy Path

* Ongoing Registration Table Improvements

* User access Start, some more table clean up

* User Access Fixes + more table updates

* Cleaned up Tables Sorting

* Further Transfer and Unit Note Adjustments

* Masking fixes and replacements

* Date Pickers and misc styling adjustments

* Lint Sweeps and camelCase enforcement

* Reg Table Fix and command revert

* Further DatePicker Updates

* ViTest: Unit Testing Setup/Config/Utils and Ongoing Refactoring (#1623)

* Ongoing Unit Test fixes

* Ongoing PPR Test fixes - Includes base setup - solves most complexity - now test fixes

* more test config updates and unit test fixes

* button-footer rework

* Further Testing updates - Up to Debtors

* continued testing updates DischargeReg

* Tests up to EditTrust and more cleanup

* PR CleanUP

* Few more tests - up to FeeSummary

* FeeSummary test

* Lint update

* fee summary file clean up

* Sync Clean Up

* Ongoing test work

* Delete .idea directory

* PPR Unit Testing Part 3 (#1631)

* Ongoing tests: nearly complete

* Only Table row and reg wrapper to complete

* setup adjustments

* Reg Wrapper and Fetching updates

* ppr testing finalized

* jest clean up and terminal clean up

* Update MHR unit tests - Part 1 (#1630)

Update unit tests

* Vue Fold in Prep: Linting Fixes  (#1633)

* ongoing Linting

* Lint Fixes

* no gutters update

* MakeModel Test Fix

* MHR Test Fixes, Misc UI fixes (#1636)

* Test Updates, Misc UI fixes

* ts config clean up

* Update Unit Tests - Part 2 (#1635)

* Further updated to unit tests

* More unit test updates

* Further unit test updates

* More unit test updates

* Fix errors in Dashboard test by mocking api calls

* Fix Signout test from error

* Fix some of Typescript errors

* 17701 Misc MHR Clean Up (#1638)

* Misc Ui clean up

* remove dev code

* remove more dev code

* Fixes after Rebase

* Fix unit tests, small cleanup (#1640)

* Delay app mount to allow for auth data (#1641)

* Delay app mount to allow for auth data

* spacing fix

* optional chain doc for testing env

* linting fixes

* test fix and spelling correction

* Console cleanup

* Fix Lien Alert message for QS (#1643)

* Fix Lien Alert message for QS

* Version update

* SbcCC Version Updates + Lien/Locked Updates (#1645)

* Authentication Flow updates

* minor syntax fix and error handling

* Remove extra console

* RL Collateral Selector fix

* Axios version and interceptor upgrades (#1646)

* sbc-cc updates (for axios V) and axios interceptor updates

* Version bump

* Fix Lien Alert msg (#1648)

* Home Owners styling and Transfer Bugs (#1649)

* Home Owners Styling and Bug fixes

* Pr Updates

---------

Co-authored-by: Dima K <dima1086@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vue3 Migration Work related to Vue3 migration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants