Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Cancelled MHR for Staff and QS #1907

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented May 31, 2024

Issue #:

Description of changes:

  • Handle Cancelled MHRs
  • Add modal for QS when trying to add Cancelled MHR to the table
  • Unit tests

Screenshot 2024-05-31 at 13 10 10

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 self-assigned this May 31, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented May 31, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1907-skxdqt7v.web.app

@@ -329,7 +337,7 @@ export default defineComponent({
// Getters
getRegTableBaseRegs, getRegTableDraftsBaseReg, isMhrRegistration, isMhrManufacturerRegistration,
getRegTableTotalRowCount, getStateModel, getRegTableDraftsChildReg, hasMorePages, getRegTableNewItem,
getRegTableSortOptions, getRegTableSortPage, getUserSettings, getMhRegTableBaseRegs, isRoleStaffReg
getRegTableSortOptions, getRegTableSortPage, getUserSettings, getMhRegTableBaseRegs, isRoleStaffReg, isRoleQualifiedSupplier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small lint item

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dimak1
Copy link
Collaborator Author

dimak1 commented May 31, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1907-skxdqt7v.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@dimak1 dimak1 merged commit 9fc851b into bcgov:main Jun 3, 2024
3 of 5 checks passed
@dimak1 dimak1 deleted the feat/cancelled-mhr branch June 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants