Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAN AMEND: UXA Feedback #1917

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Jun 6, 2024

Issue #: /bcgov/entity#

Description of changes:

  • Some Badge spacing Styling
  • Don't show Added Orders badge on Added Notices
  • Preserving Panel expansion on order removal
  • min char length added to OPTIONAL Effect of Order field - ie only validate when characters present
  • Don't show amended badge or action on Parent notice when child orders edited - Modified logic to include these changed notices into add/remove notice payload.
  • Updated Fees
Screenshot 2024-06-06 at 9 04 32 AM Screenshot 2024-06-06 at 9 05 17 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jun 6, 2024
@cameron-eyds cameron-eyds changed the title UXA Feedback Items SAN AMEND: UXA Feedback Jun 6, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1917-rpramtxt.web.app

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cameron-eyds cameron-eyds merged commit 326b95b into bcgov:main Jun 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants