Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenants in common order groups by sequence number #1959

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Tenants in common order groups by sequence number #1959

merged 2 commits into from
Jun 29, 2024

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity#22014

Description of changes:

  • Data migration capture legacy group sequence numbers.
  • Patch existing registrations.
  • Add a sequence number to represent TC group order
  • Update test data and unit tests.
  • Update response and report data to order TC groups by the sequence number.

Note: for TC transfers, corrections, amendments, re-registrations, the addOwnerGroups group.groupId is now the sequence number of the new group.
So if only modifying the second group, the addOwnerGroups[0].groupId value is 2. A UI change may be required.

Issue #: /bcgov/entity#21829

Description of changes:

  • Legacy registration if no description.baseInformation.circa value set the default to false.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett added the MHR API MHR API changes label Jun 28, 2024
@doug-lovett doug-lovett self-assigned this Jun 28, 2024
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -289,6 +289,8 @@ def registration_json(self):
description['engineerDate'] = model_utils.format_local_date(self.engineer_date)
if self.circa == '?':
description['baseInformation']['circa'] = True
else:
description['baseInformation']['circa'] = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett merged commit bdd4640 into bcgov:main Jun 29, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR API MHR API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants