Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Descriptions History #1964

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Jul 3, 2024

Issue #: /bcgov/entity#21850

Description of changes:

  • Expands the common table component for configuration (parse prop data and slots)
  • Build out template for Home Description review
  • Unit test additions

Screenshot 2024-07-03 at 2 49 10 PM

Screenshot 2024-07-03 at 4 02 48 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jul 3, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1964-o8ws350b.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment.

ppr-ui/src/components/common/SimpleTable.vue Outdated Show resolved Hide resolved
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1964-o8ws350b.web.app

@cameron-eyds cameron-eyds merged commit 9f583e9 into bcgov:main Jul 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants