-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13809 ppr search result displaying selection list #1985
13809 ppr search result displaying selection list #1985
Conversation
…-result-displaying-selection-list
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @flutistar, I noticed there are merge commits. We normally sync via |
Thanks @dimak1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good but you'll need to make a small update to the unit tests!
I got you @cameron-eyds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1985-nyr1xfz3.web.app |
Issue #: /bcgov/entity#13809
Description of changes:
tombstoneBreadcrumbMhrSearch
forMHR Search
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).