Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13809 ppr search result displaying selection list #1985

Conversation

flutistar
Copy link
Collaborator

Issue #: /bcgov/entity#13809

Description of changes:

  • Added tombstoneBreadcrumbMhrSearch for MHR Search.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@flutistar
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dimak1
Copy link
Collaborator

dimak1 commented Jul 17, 2024

Hi @flutistar, I noticed there are merge commits. We normally sync via rebase. Here is a example/workflow: https://github.com/bcgov/namex/blob/main/docs/developer.md
Screenshot 2024-07-17 at 11 37 59

@flutistar
Copy link
Collaborator Author

Thanks @dimak1
I will keep that in my mind.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good but you'll need to make a small update to the unit tests!

@flutistar
Copy link
Collaborator Author

I got you @cameron-eyds

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cameron-eyds
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1985-nyr1xfz3.web.app

@cameron-eyds cameron-eyds merged commit 71bcfcb into bcgov:main Jul 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants