Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22054-added-aria-props-to-buttons #1996

Merged
merged 3 commits into from
Aug 8, 2024
Merged

22054-added-aria-props-to-buttons #1996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8c7714
22054-added-aria-props-to-buttons
flutistar Aug 1, 2024
58c9072
changed version number
flutistar Aug 1, 2024
5549f42
removed aria-hidden options
flutistar Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.42",
"version": "3.2.43",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
8 changes: 8 additions & 0 deletions ppr-ui/src/components/tables/RegistrationTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
type="text"
label="Number"
density="compact"
aria-hidden="true"
/>
<template v-if="header.value === 'registrationType'">
<RegistrationBarTypeAheadList
Expand Down Expand Up @@ -94,6 +95,7 @@
hideDetails
density="compact"
label="Registration Type"
aria-hidden="true"
>
<template #default="item">
<span class="list-item py-3">
Expand All @@ -118,6 +120,7 @@
hideDetails
density="compact"
label="Registration Type"
aria-hideen="true"
@update:menu="isMiscTransfersEnabled ? hideAllGroups() : ''"
>
<template
Expand Down Expand Up @@ -189,6 +192,7 @@
persistentClear
:clearIcon="'mdi-close'"
@click="showDatePicker = true"
aria-hidden="true"

Check warning on line 195 in ppr-ui/src/components/tables/RegistrationTable.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-hidden" should go before "@click"
/>
<v-select
v-if="isPpr && header.value === 'statusType'"
Expand All @@ -202,6 +206,7 @@
label="Status"
clearable
density="compact"
aria-hidden="true"
/>
<v-select
v-else-if="header.value === 'statusType'"
Expand All @@ -215,6 +220,7 @@
label="Status"
clearable
density="compact"
aria-hidden="true"
/>
<v-text-field
v-if="header.value === 'registeringName'"
Expand All @@ -226,6 +232,7 @@
type="text"
label="Registered By"
density="compact"
aria-hidden="true"
/>
<v-text-field
v-if="!isPpr && header.value === 'registeringParty'"
Expand All @@ -248,6 +255,7 @@
type="text"
label=""
density="compact"
aria-hidden="true"
/>
<v-btn
v-if="header.value === 'actions' && headers.length > 1 && tableFiltersActive"
Expand Down
17 changes: 15 additions & 2 deletions ppr-ui/src/components/tables/common/TableRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,13 @@
variant="plain"
:loading="item.path === loadingPDF"
@click="downloadPDF(item)"
aria-label="Download PDF"

Check warning on line 256 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<img src="@/assets/svgs/pdf-icon-blue.svg">
<span class="pl-1">PDF</span>
<img
src="@/assets/svgs/pdf-icon-blue.svg"
role="img"
>
<span class="pl-1" aria-hidden="true">PDF</span>

Check warning on line 262 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

'aria-hidden' should be on a new line
</v-btn>
<v-tooltip
v-else-if="!isDraft(item)"
Expand Down Expand Up @@ -300,6 +304,7 @@
class="edit-btn"
color="primary"
@click="editDraft(item)"
aria-label="Edit Button"

Check warning on line 307 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<span>Edit</span>
</v-btn>
Expand All @@ -316,6 +321,8 @@
class="edit-btn"
color="primary"
@click="handleAction(item, TableActions.AMEND)"
aria-hidden="false"

Check warning on line 324 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 324 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-hidden" should go before "@click"
aria-label="Amend Button"

Check warning on line 325 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 325 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<span>Amend</span>
</v-btn>
Expand All @@ -324,6 +331,8 @@
color="primary"
class="remove-btn"
@click="handleAction(item, TableActions.REMOVE)"
aria-hidden="false"

Check warning on line 334 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 334 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-hidden" should go before "@click"
aria-label="Remove From Table Button"
>
<span class="fs-12">Remove From Table</span>
</v-btn>
Expand Down Expand Up @@ -463,6 +472,8 @@
color="primary"
class="edit-btn"
@click="openMhr(item)"
aria-hidden="false"
aria-label="Open Button"
>
<span>Open</span>
</v-btn>
Expand Down Expand Up @@ -608,6 +619,8 @@
color="primary"
class="edit-btn"
@click="openMhr(item)"
aria-hidden="false"
aria-label="Edit Button"
>
<span>Edit</span>
</v-btn>
Expand Down
Loading