Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22056 bugfix dropdown button #2000

Merged
merged 2 commits into from
Aug 15, 2024
Merged

22056 bugfix dropdown button #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d70dd
temp commit
flutistar Aug 14, 2024
aaf8471
Added aria label to expand button to table row
flutistar Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.43",
"version": "3.2.44",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 2 additions & 0 deletions ppr-ui/src/components/tables/common/TableRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
color="primary"
size="small"
icon
:aria-label="isPpr ? 'Expand Amendments' : 'Expand History'"
role="button"
@click="toggleExpand(item)"
@mouseover="rollover = true"
@mouseleave="rollover = false"
Expand Down Expand Up @@ -253,13 +255,13 @@
variant="plain"
:loading="item.path === loadingPDF"
@click="downloadPDF(item)"
aria-label="Download PDF"

Check warning on line 258 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<img
src="@/assets/svgs/pdf-icon-blue.svg"
role="img"
>
<span class="pl-1" aria-hidden="true">PDF</span>

Check warning on line 264 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

'aria-hidden' should be on a new line
</v-btn>
<v-tooltip
v-else-if="!isDraft(item)"
Expand Down Expand Up @@ -304,7 +306,7 @@
class="edit-btn"
color="primary"
@click="editDraft(item)"
aria-label="Edit Button"

Check warning on line 309 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<span>Edit</span>
</v-btn>
Expand All @@ -321,8 +323,8 @@
class="edit-btn"
color="primary"
@click="handleAction(item, TableActions.AMEND)"
aria-hidden="false"

Check warning on line 326 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 326 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-hidden" should go before "@click"
aria-label="Amend Button"

Check warning on line 327 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 327 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-label" should go before "@click"
>
<span>Amend</span>
</v-btn>
Expand All @@ -331,7 +333,7 @@
color="primary"
class="remove-btn"
@click="handleAction(item, TableActions.REMOVE)"
aria-hidden="false"

Check warning on line 336 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Expected indentation of 12 spaces but found 13 spaces

Check warning on line 336 in ppr-ui/src/components/tables/common/TableRow.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1) 

Attribute "aria-hidden" should go before "@click"
aria-label="Remove From Table Button"
>
<span class="fs-12">Remove From Table</span>
Expand Down
Loading