Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed owner group type as NA #2011

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

flutistar
Copy link
Collaborator

Issue #: /bcgov/entity#22264

Description of changes:
Since we push deleted owner under if (ownerGroup.owners.some(owner => owner.action === ActionTypes.REMOVED)) condition, we don't need ownerGroup.owners.filter(owner => owner.action === ActionTypes.REMOVED).length > 1 and the type is always JOINT

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very nervous about home owner changes, as these components support a dozen flows with a dozen different rule sets.

If you confident in these changes however and it's been weighed as a critical fix, then the code looks good to me.

@flutistar
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutistar
Copy link
Collaborator Author

I'm very nervous about home owner changes, as these components support a dozen flows with a dozen different rule sets.

If you confident in these changes however and it's been weighed as a critical fix, then the code looks good to me.

I will keep the current rule as it is, and add new condition for TRANS_WILL

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2011-3hw2g56l.web.app

@cameron-eyds
Copy link
Collaborator

I'm very nervous about home owner changes, as these components support a dozen flows with a dozen different rule sets.
If you confident in these changes however and it's been weighed as a critical fix, then the code looks good to me.

I will keep the current rule as it is, and add new condition for TRANS_WILL

Totally up to you, is the fix required for all Transfers?

@flutistar
Copy link
Collaborator Author

I'm very nervous about home owner changes, as these components support a dozen flows with a dozen different rule sets.
If you confident in these changes however and it's been weighed as a critical fix, then the code looks good to me.

I will keep the current rule as it is, and add new condition for TRANS_WILL

Totally up to you, is the fix required for all Transfers?

Nope, just for TO_EXECUTOR_PROBATE_WILL transfer type.

@flutistar
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2011-3hw2g56l.web.app

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flutistar flutistar merged commit 1ec5cf0 into bcgov:main Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants