update goodStanding validator for search_api and add tests

bcgov · Sep 15, 2023 · 0e1bbf1 · 0e1bbf1
1 parent 8667477
commit 0e1bbf1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/search-api/src/search_api/services/validator.py b/search-api/src/search_api/services/validator.py
@@ -81,9 +81,9 @@ def validate_solr_update_request(request_json: dict):  # pylint: disable=too-man
 
         good_standing_path = '/business/goodStanding'
         good_standing = get_str(request_json, good_standing_path)
-
-        if good_standing is not None and good_standing not in ['true', 'false']:
-            err.append({'error': 'Good standing must be "true" or "false".', 'path': good_standing_path})
+        if good_standing is not None:
+            if not (good_standing == 'None' or good_standing.lower() == 'true' or good_standing.lower() == 'false'):
+                err.append({'error': 'Good standing must be a valid boolean value', 'path': good_standing_path})
 
         for index, party in enumerate(request_json.get('parties', [])):
 

diff --git a/search-api/tests/unit/api/internal/test_update_solr.py b/search-api/tests/unit/api/internal/test_update_solr.py
@@ -68,8 +68,12 @@ def test_update_business_in_solr(session, client, jwt, mocker):
 @integration_solr
 @pytest.mark.parametrize('test_name, legal_name, good_standing, tax_id', [
     ('remove-tax-id', 'ABCD Prop', 'true', None),
-    ('update-good-standing', 'ABCD Prop', 'false', '123456789'),
     ('update-legal-name', 'ABCDE Prop', 'true', '123456789'),
+    ('update-good-standing-string-false', 'ABCD Prop', 'false', '123456789'),
+    ('update-good-standing-string-true', 'ABCD Prop', 'true', '123456789'),
+    ('update-good-standing-boolean-false', 'ABCD Prop', False, '123456789'),
+    ('update-good-standing-boolean-true', 'ABCD Prop', True, '123456789'),
+    ('update-good-standing-none', 'ABCD Prop', None, '123456789'),
 ])
 def test_update_business_in_solr_with_varying_data(session, client, jwt, mocker, test_name, legal_name, good_standing, tax_id):
     """Assert that update operation is successful."""