Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes #178

Merged
merged 2 commits into from
Oct 28, 2022
Merged

bug fixes #178

merged 2 commits into from
Oct 28, 2022

Conversation

kialj876
Copy link
Collaborator

Signed-off-by: Kial Jinnah kialjinnah@gmail.com

Issue #: /bcgov/entity#13255 bcgov/entity#13257 bcgov/entity#13900

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 requested a review from lmallika86 October 28, 2022 18:37
@kialj876 kialj876 self-assigned this Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #178 (bc22438) into main (535792d) will decrease coverage by 0.06%.
The diff coverage is 57.50%.

❗ Current head bc22438 differs from pull request most recent head b8aaa92. Consider uploading reports for the commit b8aaa92 to get more accurate results

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   68.24%   68.18%   -0.07%     
==========================================
  Files          56       56              
  Lines        1940     1952      +12     
  Branches      237      240       +3     
==========================================
+ Hits         1324     1331       +7     
- Misses        551      556       +5     
  Partials       65       65              
Flag Coverage Δ
search-api 68.18% <57.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/search_api/resources/v1/internal/update_solr.py 29.09% <6.66%> (-1.53%) ⬇️
search-api/src/search_api/services/validator.py 86.56% <83.33%> (+0.85%) ⬆️
...i/src/search_api/resources/v1/businesses/search.py 61.59% <100.00%> (ø)
search-api/src/search_api/services/solr.py 75.53% <100.00%> (+0.21%) ⬆️
search-api/src/search_api/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 merged commit 35792cc into bcgov:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants