Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user info with jwt info #179

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

kialj876
Copy link
Collaborator

Signed-off-by: Kial Jinnah kialjinnah@gmail.com

Issue #: /bcgov/entity#13858

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 requested a review from lmallika86 October 31, 2022 19:46
@kialj876 kialj876 self-assigned this Oct 31, 2022
@@ -35,6 +35,11 @@ def get(request_id=None):
if not account_id:
return resource_utils.account_required_response()

# updates user information with given jwt
user = User.get_or_create_user_by_jwt(g.jwt_oidc_token_info)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I added this in so that it would update the user info in our db when they attempt to get their active requests, but it is not used for anything

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #179 (be28b75) into main (535792d) will increase coverage by 0.05%.
The diff coverage is 64.15%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   68.24%   68.29%   +0.05%     
==========================================
  Files          56       56              
  Lines        1940     1962      +22     
  Branches      237      243       +6     
==========================================
+ Hits         1324     1340      +16     
- Misses        551      557       +6     
  Partials       65       65              
Flag Coverage Δ
search-api 68.29% <64.15%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/search_api/resources/v1/internal/update_solr.py 29.09% <6.66%> (-1.53%) ⬇️
...i/src/search_api/resources/v1/purchase_requests.py 60.60% <66.66%> (-2.73%) ⬇️
search-api/src/search_api/services/validator.py 86.56% <83.33%> (+0.85%) ⬆️
search-api/src/search_api/models/user.py 98.73% <100.00%> (+1.51%) ⬆️
...i/src/search_api/resources/v1/businesses/search.py 61.59% <100.00%> (ø)
search-api/src/search_api/services/solr.py 75.53% <100.00%> (+0.21%) ⬆️
search-api/src/search_api/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 merged commit c870136 into bcgov:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants