-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request doc gen #201
Request doc gen #201
Conversation
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com> Signed-off-by: Kial Jinnah <kialjinnah@gmail.com> Co-authored-by: Kial Jinnah <kialjinnah@gmail.com>
search-api/src/search_api/resources/v1/businesses/documents/document_request.py
Show resolved
Hide resolved
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com> Signed-off-by: Kial Jinnah <kialjinnah@gmail.com> Co-authored-by: Kial Jinnah <kialjinnah@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 68.24% 65.43% -2.81%
==========================================
Files 56 57 +1
Lines 1940 2092 +152
Branches 237 278 +41
==========================================
+ Hits 1324 1369 +45
- Misses 551 647 +96
- Partials 65 76 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Issue #: series of tix
Description of changes:
doing this as an initial draft as the full test suite requires solr, so that might need to get moved.
integration testing with pubsub should get added, possibly add an e2e for the doc pull
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).