Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request doc gen #201

Merged
merged 47 commits into from
Nov 23, 2022
Merged

Request doc gen #201

merged 47 commits into from
Nov 23, 2022

Conversation

thorwolpert
Copy link
Collaborator

Issue #: series of tix

Description of changes:

  • changes to session and db creation
  • add source to users
  • add ops/ff to calling queue
  • need to determine how best to track failures to place on queue

doing this as an initial draft as the full test suite requires solr, so that might need to get moved.
integration testing with pubsub should get added, possibly add an e2e for the doc pull

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@thorwolpert thorwolpert requested a review from kialj876 November 15, 2022 19:48
Kial and others added 2 commits November 16, 2022 09:34
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Co-authored-by: Kial Jinnah <kialjinnah@gmail.com>
@thorwolpert thorwolpert marked this pull request as ready for review November 23, 2022 22:21
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #201 (0314254) into main (535792d) will decrease coverage by 2.80%.
The diff coverage is 68.58%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   68.24%   65.43%   -2.81%     
==========================================
  Files          56       57       +1     
  Lines        1940     2092     +152     
  Branches      237      278      +41     
==========================================
+ Hits         1324     1369      +45     
- Misses        551      647      +96     
- Partials       65       76      +11     
Flag Coverage Δ
search-api 65.43% <68.58%> (-2.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/search_api/resources/v1/internal/update_solr.py 29.09% <6.66%> (-1.53%) ⬇️
search-api/src/search_api/utils/logging.py 55.10% <50.00%> (-22.68%) ⬇️
search-api/src/search_api/services/queue.py 55.31% <54.34%> (+8.26%) ⬆️
search-api/src/search_api/models/user.py 87.50% <56.00%> (-9.73%) ⬇️
...i/src/search_api/resources/v1/purchase_requests.py 60.60% <66.66%> (-2.73%) ⬇️
search-api/src/search_api/services/flags.py 64.86% <67.24%> (-30.79%) ⬇️
search-api/src/search_api/services/authz.py 62.50% <79.16%> (-0.44%) ⬇️
...ources/v1/businesses/documents/document_request.py 80.51% <83.33%> (-0.44%) ⬇️
search-api/src/search_api/services/validator.py 86.56% <83.33%> (+0.85%) ⬆️
search-api/src/search_api/__init__.py 95.08% <100.00%> (+0.43%) ⬆️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thorwolpert thorwolpert merged commit 14b2fcc into bcgov:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants