Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoSuggest API Integration + UI fixes #21

Merged
merged 2 commits into from
May 10, 2022
Merged

AutoSuggest API Integration + UI fixes #21

merged 2 commits into from
May 10, 2022

Conversation

lmallika86
Copy link

@lmallika86 lmallika86 commented May 10, 2022 •
edited
Loading

@lmallika86 lmallika86 requested a review from kialj876 May 10, 2022 20:23
kialj876
kialj876 reviewed May 10, 2022
View reviewed changes
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Lekshmi this looks great. I have several minor comments for organizational things, but let me know if you disagree or prefer it differently!

search-ui/src/requests/search-api.ts Outdated Show resolved Hide resolved
search-ui/src/requests/search-api.ts Outdated Show resolved Hide resolved
search-ui/src/interfaces/corp-type.ts Outdated Show resolved Hide resolved
search-ui/src/interfaces/corp-type.ts Outdated Show resolved Hide resolved
search-ui/src/interfaces/corp-type.ts Outdated Show resolved Hide resolved
@lmallika86
Copy link
Author

Hey Lekshmi this looks great. I have several minor comments for organizational things, but let me know if you disagree or prefer it differently!

The only thing is for autosuggest we may not want to bubble up the error to the app level. So I just did a console.error where the function is called

kialj876
kialj876 approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@kialj876 kialj876 merged commit 0ac51e6 into bcgov:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kialj876 kialj876 kialj876 approved these changes

Assignees

@lmallika86 lmallika86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmallika86 @kialj876