Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21273 - Added alert for businesses in the process of being dissolved #261

Merged

Conversation

JazzarKarim
Copy link
Contributor

Issue #: /bcgov/entity#21273

Description of changes:

  • Added an alert for businesses that are in the process of being dissolved
  • Misc. Fixes
  • Unit test fixes

business in the process of dissolution

Designs followed: https://preview.uxpin.com/4648cf2627971eb4281b7ccc7c1258224b3d8084#/pages/164129752/simulate/sitemap

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@@ -9,9 +9,9 @@ export const RegistriesInfo: ContactInfoI[] = [
},
{
icon: 'mdi-phone',
href: 'tel:+1-250-952-0568',
href: 'tel:+1-250-387-7848',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this is super out of date. If you look at the designs (https://preview.uxpin.com/4648cf2627971eb4281b7ccc7c1258224b3d8084#/pages/164129752/simulate/sitemap) and what we have in other repos, this is the number being used for "Victoria Office".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know -- I will double check the other UIs BTR is managing

@kialj876
Copy link
Collaborator

kialj876 commented Jun 5, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://registry-search-dev--pr-261-a4qv92k2.web.app

@kialj876
Copy link
Collaborator

kialj876 commented Jun 5, 2024

/gcbrun

@JazzarKarim
Copy link
Contributor Author

You can search for "BC0878513" for a business that's in the process of being dissolved.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://registry-search-dev--pr-261-a4qv92k2.web.app

@kialj876
Copy link
Collaborator

kialj876 commented Jun 5, 2024

Nice work 👍

@kialj876 kialj876 merged commit 59f49ab into bcgov:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants