Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Request Get Endpoint #62

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Document Request Get Endpoint #62

merged 3 commits into from
Jun 10, 2022

Conversation

lmallika86
Copy link

Issue #: /bcgov/entity#12414

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@lmallika86 lmallika86 self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #62 (5800220) into main (f80b266) will increase coverage by 0.91%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   73.56%   74.48%   +0.91%     
==========================================
  Files          35       36       +1     
  Lines        1078     1109      +31     
  Branches      116      121       +5     
==========================================
+ Hits          793      826      +33     
+ Misses        263      260       -3     
- Partials       22       23       +1     
Flag Coverage Δ
search-api 74.48% <87.50%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch_api/resources/v1/businesses/document_request.py 86.66% <86.66%> (ø)
...src/search_api/resources/v1/businesses/__init__.py 100.00% <100.00%> (ø)
search-api/src/search_api/resources/utils.py 44.82% <0.00%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9638680...5800220. Read the comment docs.

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@kialj876
Copy link
Collaborator

kialj876 commented Jun 8, 2022

Oh it would be awesome if you could add a postman test with a saved example of an output for the new endpoint (see the other ones to see what I mean)

Lekshmi Mallika added 2 commits June 8, 2022 16:18
@lmallika86
Copy link
Author

Oh it would be awesome if you could add a postman test with a saved example of an output for the new endpoint (see the other ones to see what I mean)

Yes, Planning to add it with the post endpoint PR

@lmallika86 lmallika86 merged commit aeacc4f into bcgov:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants