Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gateway code + document updates #73

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

kialj876
Copy link
Collaborator

Signed-off-by: Kial Jinnah kialjinnah@gmail.com

Issue #: /bcgov/entity#12412

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

kialj876 added 2 commits June 15, 2022 17:51
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 requested a review from lmallika86 June 16, 2022 00:57
@kialj876 kialj876 self-assigned this Jun 16, 2022
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #73 (bc4c96e) into main (6a2021d) will decrease coverage by 0.14%.
The diff coverage is 63.04%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   70.54%   70.40%   -0.15%     
==========================================
  Files          49       51       +2     
  Lines        1477     1490      +13     
  Branches      162      165       +3     
==========================================
+ Hits         1042     1049       +7     
- Misses        405      411       +6     
  Partials       30       30              
Flag Coverage Δ
search-api 70.40% <63.04%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...api/resources/v1/businesses/documents/documents.py 33.92% <31.57%> (-1.49%) ⬇️
...h_api/services/document_storage/storage_service.py 45.94% <42.85%> (ø)
search-api/src/search_api/enums/__init__.py 100.00% <100.00%> (ø)
search-api/src/search_api/enums/document_type.py 100.00% <100.00%> (ø)
search-api/src/search_api/models/document.py 100.00% <100.00%> (ø)
...equest_handlers/document_access_request_handler.py 92.30% <100.00%> (+0.15%) ⬆️
...ources/v1/businesses/documents/document_request.py 81.48% <100.00%> (ø)
search-api/src/search_api/services/entity.py 28.57% <100.00%> (ø)
search-api/src/search_api/services/payment.py 52.17% <100.00%> (ø)
search-api/src/search_api/services/validator.py 91.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d741735...bc4c96e. Read the comment docs.

@kialj876 kialj876 merged commit fba3ffd into bcgov:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants