Business Search to tabbed interface #90
Conversation
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 70.27% 70.87% +0.60%
==========================================
Files 52 54 +2
Lines 1497 1631 +134
Branches 168 193 +25
==========================================
+ Hits 1052 1156 +104
- Misses 415 437 +22
- Partials 30 38 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -119,6 +119,10 @@ class _Config(): # pylint: disable=too-few-public-methods | |||
| except (TypeError, ValueError): | |||
| JWT_OIDC_JWKS_CACHE_TIMEOUT = 300 | |||
|
|
|||
| JWT_OIDC_USERNAME = os.getenv('JWT_OIDC_USERNAME', 'username') | |||
| JWT_OIDC_FIRSTNAME = os.getenv('JWT_OIDC_FIRSTNAME', 'firstname') | |||
| JWT_OIDC_LASTNAME = os.getenv('JWT_OIDC_LASTNAME', 'lastname') | |||
There was a problem hiding this comment.
what are these used for? Were they left in by mistake?
There was a problem hiding this comment.
Yes, This is the reason why user details were not getting saved in the db
|
|
||
| const { search } = useSearch() | ||
|
|
||
| const totalResultsLength = computed(() => search.results?.length || 0 ) |
There was a problem hiding this comment.
fyi this will actually be the wrong value if the number of results is greater than the rows specified. The total will be here: search.searchResults.total_rows
(this is an existing bug)
There was a problem hiding this comment.
Oh but what is the expected behavior in this case?
There was a problem hiding this comment.
Well I would have it show the full total since we'll be adding paging in
There was a problem hiding this comment.
But I guess that can wait until we implement paging on the front end
Test is fixed. I will add postman test in another PR |
Issue #: /bcgov/entity#12641
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).