Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12433 support multiple legal types filter #91

Merged

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Jul 6, 2022

Issue #: /bcgov/entity#12433

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

kialj876 added 2 commits July 5, 2022 17:55
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 self-assigned this Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #91 (e15c952) into main (9969d52) will increase coverage by 0.78%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   70.27%   71.05%   +0.78%     
==========================================
  Files          52       53       +1     
  Lines        1497     1603     +106     
  Branches      168      192      +24     
==========================================
+ Hits         1052     1139      +87     
- Misses        415      428      +13     
- Partials       30       36       +6     
Flag Coverage Δ
search-api 71.05% <72.22%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
search-api/src/search_api/services/solr.py 72.91% <57.47%> (+3.38%) ⬆️
...i/src/search_api/resources/v1/businesses/search.py 75.55% <79.59%> (-4.68%) ⬇️
...arch-api/src/search_api/request_handlers/search.py 86.66% <86.66%> (ø)
...ch-api/src/search_api/request_handlers/__init__.py 100.00% <100.00%> (ø)
search-api/src/search_api/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e9af5...e15c952. Read the comment docs.

@kialj876
Copy link
Collaborator Author

kialj876 commented Jul 6, 2022

/gcbrun

@kialj876 kialj876 merged commit 3066001 into bcgov:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants