-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VI print police copy and submit #173
Conversation
rsbc-roadside-forms-form-handler:latest (redhat 8.8) - Trivy Report - 2023-10-05 19:31:37.410630718 +0000 UTC m=+0.334749802
|
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-05 19:32:02.961849183 +0000 UTC m=+0.407515543
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-05 19:35:14.384949576 +0000 UTC m=+0.380378450
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated comments
form_id_vi=event.vi_form.form_id, | ||
event_id=event.event_id, | ||
form_type='VI', | ||
storage_key=f'test/{encoded_file_name}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the folder name should be read from an env variable. There is already an env variable passed on line 160. Thats the folder name (bucket name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to be the same as the config bucket
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-10 16:23:29.442154489 +0000 UTC m=+0.360700154
|
rsbc-roadside-forms-form-handler:latest (redhat 8.8) - Trivy Report - 2023-10-10 16:23:54.834423199 +0000 UTC m=+0.452385875
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-10 16:25:27.927454241 +0000 UTC m=+0.267077876
|
rsbc-roadside-forms-form-handler:latest (redhat 8.8) - Trivy Report - 2023-10-10 18:31:08.670200019 +0000 UTC m=+0.364427050
|
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-10 18:31:19.291522767 +0000 UTC m=+0.368862143
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-10 18:33:10.171324648 +0000 UTC m=+0.286046260
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-10 21:41:07.238359466 +0000 UTC m=+0.353637346
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-10 21:43:00.28834962 +0000 UTC m=+0.303708713
|
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-10 21:56:59.094456631 +0000 UTC m=+0.533744371
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-10 21:58:16.838576089 +0000 UTC m=+0.280437935
|
rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-10-10 22:13:04.189703825 +0000 UTC m=+0.472205642
|
rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-10-10 22:14:37.816644103 +0000 UTC m=+0.315492379
|
SonarCloud Quality Gate failed. 1 Bug 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This adds in the functionality to view police copy of the VI form, and submission of the VI form. Saves the event data and creates a PDF drom the form image and saves it to the Minio bucket as an encrypted file.