Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoil Forms & Nav Guards & Bug Fixes #204

Merged
merged 8 commits into from
Nov 23, 2023
Merged

Spoil Forms & Nav Guards & Bug Fixes #204

merged 8 commits into from
Nov 23, 2023

Conversation

sam-warren
Copy link
Contributor

@sam-warren sam-warren commented Nov 23, 2023

This ticket encapsulates:

  • DF-2843
  • DF-2842
  • DF-2845

It also includes a router refactor upgrading it to react-router-dom v6.19.0. This allows us to use the useBlocker() hook to prevent user nav before confirming. This also does away with fetching new IDs when all are leased, and instead unleases IDs from forms that do not end up submitted. It also gets rid of the massive scrollbar on the right side of the page.

@sam-warren sam-warren changed the base branch from main to release/1.0 November 23, 2023 01:58
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-11-23 02:01:03.69775679 +0000 UTC m=+0.284336843

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-11-23 02:02:45.498634616 +0000 UTC m=+0.274287814

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-11-23 02:02:46.790287742 +0000 UTC m=+0.198458998

redhat
No Vulnerabilities found
No Misconfigurations found

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2023-11-23 02:04:11.983978675 +0000 UTC m=+0.187914642

redhat
No Vulnerabilities found
No Misconfigurations found

Copy link
Contributor

@JustinMacaulay JustinMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sam-warren sam-warren merged commit 39ec588 into release/1.0 Nov 23, 2023
18 of 25 checks passed
@sam-warren sam-warren deleted the void-forms branch November 23, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants